-
Notifications
You must be signed in to change notification settings - Fork 53
feat: added new Sample with visualtest for formfields with label #10673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
aca73dd
Added new Sample with visualtest for formfields with label
ItzGerSte 3bce7a1
Update all snapshots
ItzGerSte ed009c7
Merge remote-tracking branch 'origin/develop' into 242-app-sample-for…
ItzGerSte 0563387
Update all snapshots
ItzGerSte a969b01
Merge branch 'develop' into 242-app-sample-for-form-fields-with-label
ItzGerSte 665a0ce
Merge branch 'develop' into 242-app-sample-for-form-fields-with-label
ItzGerSte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
packages/samples/react/src/scenarios/same-height-of-all-form-elements-with-label.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import { | ||
| KolCombobox, | ||
| KolInputColor, | ||
| KolInputDate, | ||
| KolInputEmail, | ||
| KolInputFile, | ||
| KolInputNumber, | ||
| KolInputPassword, | ||
| KolInputRange, | ||
| KolInputText, | ||
| KolSelect, | ||
| KolSingleSelect, | ||
| KolTextarea, | ||
| } from '@public-ui/react-v19'; | ||
| import type { FC } from 'react'; | ||
| import React from 'react'; | ||
| import { SampleDescription } from '../components/SampleDescription'; | ||
|
|
||
| export const SameHeightOfAllFormElements: FC = () => { | ||
| return ( | ||
| <> | ||
| <SampleDescription> | ||
| <p>All form elements with labels, should have the same height and gaps to ensure a consistent and visually balanced user interface.</p> | ||
| </SampleDescription> | ||
| <div className="w-full flex flex-wrap gap-4"> | ||
| <KolCombobox _icons="kolicon-house" _label="Combobox" _suggestions={[]} /> | ||
| <KolInputColor | ||
| _icons={{ | ||
| left: 'kolicon-house', | ||
| }} | ||
| _label="Input-Color" | ||
| /> | ||
| <KolInputFile _icons="kolicon-house" _label="Input-File" /> | ||
| <KolInputDate _icons="kolicon-house" _label="Input-Date" /> | ||
| <KolInputEmail _icons="kolicon-house" _label="Input-Email" /> | ||
| <KolInputNumber _icons="kolicon-house" _label="Input-Number" /> | ||
| <KolInputPassword _icons="kolicon-house" _label="Input-Password" /> | ||
| <KolInputRange _icons="kolicon-house" _label="Input-Range" /> | ||
| <KolInputText _icons="kolicon-house" _label="Input-Text" /> | ||
| <KolSelect _icons="kolicon-house" _label="Select" _options={[]} /> | ||
| <KolSingleSelect _icons="kolicon-house" _label="Single Select" _options={[]} /> | ||
| <KolTextarea _icons="kolicon-house" _label="Textarea" /> | ||
| </div> | ||
| </> | ||
| ); | ||
| }; |
Binary file added
BIN
+41.6 KB
...hot-for-scenarios-same-height-of-all-form-elements-with-label-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+60 Bytes
(100%)
...emes/default/snapshots/theme-default/snapshot-for-alert-basic-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+170 Bytes
(100%)
...s/default/snapshots/theme-default/snapshot-for-alert-card-msg-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+1 Byte
(100%)
.../default/snapshots/theme-default/snapshot-for-button-disabled-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-48 Bytes
(100%)
...efault/snapshots/theme-default/snapshot-for-button-hide-label-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-18 Bytes
(100%)
.../default/snapshots/theme-default/snapshot-for-button-variants-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+314 Bytes
(100%)
...hots/theme-default/snapshot-for-combobox-basic-noColumns-zoom-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+66 Bytes
(100%)
.../default/snapshots/theme-default/snapshot-for-form-error-list-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+121 Bytes
(100%)
...ots/theme-default/snapshot-for-input-checkbox-basic-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+61 Bytes
(100%)
...ts/theme-default/snapshot-for-input-checkbox-button-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+67 Bytes
(100%)
...ts/theme-default/snapshot-for-input-checkbox-switch-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+70 Bytes
(100%)
...pshots/theme-default/snapshot-for-input-color-basic-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+76 Bytes
(100%)
...apshots/theme-default/snapshot-for-input-date-basic-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+68 Bytes
(100%)
...pshots/theme-default/snapshot-for-input-email-basic-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+47 Bytes
(100%)
...apshots/theme-default/snapshot-for-input-file-basic-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+130 Bytes
(100%)
...shots/theme-default/snapshot-for-input-number-basic-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+99 Bytes
(100%)
...ots/theme-default/snapshot-for-input-password-basic-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+592 Bytes
(100%)
...pshots/theme-default/snapshot-for-input-radio-basic-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+110 Bytes
(100%)
...pshots/theme-default/snapshot-for-input-range-basic-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+25 Bytes
(100%)
...apshots/theme-default/snapshot-for-input-text-basic-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+34 Bytes
(100%)
...hots/theme-default/snapshot-for-input-text-disabled-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+20 Bytes
(100%)
...ts/theme-default/snapshot-for-input-text-hide-label-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+29 Bytes
(100%)
...hots/theme-default/snapshot-for-input-text-hide-msg-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+15 Bytes
(100%)
...theme-default/snapshot-for-input-text-message-types-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+34 Bytes
(100%)
...shots/theme-default/snapshot-for-input-text-variant-noColumns-firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+94 Bytes
(100%)
...t/snapshots/theme-default/snapshot-for-link-button-basic-zoom-firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-47 Bytes
(100%)
...shots/theme-default/snapshot-for-modal-basic-show-dialog-true-firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+40.7 KB
...hot-for-scenarios-same-height-of-all-form-elements-with-label-firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+168 Bytes
(100%)
...t/snapshots/theme-default/snapshot-for-select-basic-noColumns-firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+71 Bytes
(100%)
...hots/theme-default/snapshot-for-single-select-basic-noColumns-firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+51 Bytes
(100%)
...snapshots/theme-default/snapshot-for-textarea-basic-noColumns-firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+28 Bytes
(100%)
...fault/snapshots/theme-default/snapshot-for-toast-configurator-firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
+19 Bytes
(100%)
...es/default/snapshots/theme-default/snapshot-for-toolbar-basic-firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+49.2 KB
...hot-for-scenarios-same-height-of-all-form-elements-with-label-firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+41.6 KB
...hot-for-scenarios-same-height-of-all-form-elements-with-label-firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+45.8 KB
...hot-for-scenarios-same-height-of-all-form-elements-with-label-firefox-linux.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.