feat(link): migrate to skeleton architecture - #10652
Draft
deleonio wants to merge 3 commits into
Draft
Conversation
deleonio
commented
Aug 6, 2026
deleonio
commented
Contributor
- Replaces legacy WC pattern with BaseWebComponent
- Consolidates shadow.tsx into single component.tsx
- Adds functional component and controller layers
- Updates 8 dependent components to use new link
- Removes kol-link-wc tag and internal references
- Preserves all link behavior and accessibility
- Enables future performance and maintainability gains
deleonio
marked this pull request as draft
August 6, 2026 12:29
Contributor
|
🚀 MCP preview deployed to Vercel: https://kolibri-hj0e0hfld-public-ui-kolibri-mcp.vercel.app |
Contributor
|
Netlify Draft Deployment |
Contributor
|
🚀 Preview deployed to GitHub Pages: https://public-ui.github.io/kolibri/pr-10652/9d0ccc4/ |
deleonio
added
the
release:improvement
Contributor
📸 Visual Test Reports
Run: https://github.com/public-ui/kolibri/actions/runs/31107282968 |
- Replaces legacy two-element pattern with single BaseWebComponent - Implements LinkFC, LinkController, and prop definitions - Removes kol-link-wc and updates all consuming components - Moves shared link styles to BEM-compliant structure - Preserves all existing link functionality and behavior - Updates component registry and Stencil config accordingly
deleonio
force-pushed
the
refactor/migrate-kol-link-skeleton-2th
branch
from
August 6, 2026 13:43
7c8405b to
f4e8cbe
Compare
- Renamed BaseController to BaseAspect - Renamed 11 controllers to aspects - Renamed TooltipController to TooltipBehavior - Updated all documentation and references - Maintained type safety and state management - Preserved component functionality and API
- Maintains legacy DOM access for consumer CSS - Renders LinkFC directly into light DOM - Replaces kol-link in legacy components - Enables smooth migration to skeleton pattern - Preserves .kol-link class accessibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.