Skip to content

fix: reject incomplete TweetDetail responses - #75

Open
LuciusChen wants to merge 1 commit into
public-clis:mainfrom
LuciusChen:fix/issue-53-tweet-detail-validation
Open

fix: reject incomplete TweetDetail responses#75
LuciusChen wants to merge 1 commit into
public-clis:mainfrom
LuciusChen:fix/issue-53-tweet-detail-validation

Conversation

@LuciusChen

Copy link
Copy Markdown
Contributor

Summary

  • require TweetDetail results to contain the requested focal tweet
  • return a structured not_found error instead of ok: true with empty or reply-only data
  • place the focal tweet before replies for stable CLI rendering
  • add client and CLI regression coverage

This keeps downstream JSON consumers from treating an incomplete parse as a successful tweet read.

Fixes #53.

Validation

  • 245 passed, 6 deselected
  • ruff check .
  • mypy twitter_cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tweet detail returns success with empty data for real tweet IDs

1 participant