Skip to content

fix: bootstrap ClientTransaction from responsive home #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LuciusChen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: bootstrap ClientTransaction from responsive home #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,44 @@ def test_handles_malformed_html(self):
# ── TwitterClient._build_headers ─────────────────────────────────────────

class TestBuildHeaders:
@patch("twitter_cli.client._update_features_from_html")
@patch("twitter_cli.client.ClientTransaction")
@patch(
"twitter_cli.client.get_ondemand_file_url",
return_value="https://abs.twimg.com/responsive-web/client-web/ondemand.s.js",
)
@patch("twitter_cli.client._gen_ct_headers", return_value={"User-Agent": "test"})
@patch("twitter_cli.client._get_cffi_session")
def test_client_transaction_bootstraps_from_responsive_home_page(
self,
mock_session_factory,
_mock_headers,
_mock_ondemand_url,
mock_client_transaction,
mock_update_features,
):
home_page = MagicMock(content=b"<html></html>", text="<html></html>")
ondemand_file = MagicMock(text="ondemand bundle")
mock_session_factory.return_value.get.side_effect = [home_page, ondemand_file]

client = TwitterClient.__new__(TwitterClient)
client._ct_init_attempted = False
client._client_transaction = None
client._load_ct_cache = MagicMock(return_value=False)
client._save_ct_cache = MagicMock()

client._ensure_client_transaction()

first_request = mock_session_factory.return_value.get.call_args_list[0]
assert first_request.args[0] == "https://x.com/home"
assert first_request.kwargs == {
"headers": {"User-Agent": "test"},
"timeout": 10,
}
mock_client_transaction.assert_called_once()
mock_update_features.assert_called_once_with("<html></html>")
client._save_ct_cache.assert_called_once_with("<html></html>", "ondemand bundle")

@patch("twitter_cli.client._get_cffi_session")
@patch("twitter_cli.client._gen_ct_headers", return_value={})
def test_required_headers_present(self, mock_ct_headers, mock_session):
Expand Down
2 changes: 1 addition & 1 deletion twitter_cli/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,7 +1104,7 @@ def _ensure_client_transaction(self):
cffi_session = _get_cffi_session()
ct_headers = _gen_ct_headers()
home_page = cffi_session.get(
"https://x.com", headers=ct_headers, timeout=10,
"https://x.com/home", headers=ct_headers, timeout=10,
)
home_page_response = bs4.BeautifulSoup(home_page.content, "html.parser")
ondemand_url = get_ondemand_file_url(response=home_page_response)
Expand Down
Loading