Revert marginal micro-optimizations, keep only significant performance wins#4
Merged
Merged
Conversation
…nificant performance wins Co-authored-by: pubkey <8926560+pubkey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor to retain only significant performance optimizations
Revert marginal micro-optimizations, keep only significant performance wins
Mar 20, 2026
pubkey
marked this pull request as ready for review
March 20, 2026 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork added many performance optimizations over upstream
kofrasa/mingo. Some yield 5-20x improvements; others are micro-optimizations (charCode loops, indexed for-loops, manual string parsing) that marginally help while hurting readability. This PR reverts the marginal ones.Benchmarks (upstream → all opts → significant only)
~95% of gains retained. All 1,859 tests pass.
Reverted (marginal, hurt readability)
isOperatorcharCode loop → back to regexisDigitStrcharCode loop → compiled regexcharCodeAt(0) === 0x24→[0] === "$"typeOfexplicit if-chain → original hash lookuphas,normalizemanual for-loops →.every(),.some()walkindexOf/substring → split/join_hash.tsindexed loops →for...ofquery.ts,Context.initObject.keys+index → Object.entriesKept (significant wins)
isObjectinline — bypassestypeOfoverhead on the hottest pathresolve()fast paths — 1-segment and 2-segment short circuits, pre-splitpathArrayparameter$elemMatchrewrite — compiles innerQueryonce at build time instead of per-documentContext.from()single-context fast path — skips allocation when only one context$inSet fast path — O(n+m) viaSet.has()for primitive arraysmingoCmpnumber/string fast paths — skipstypeOffor the two most common comparison typesisEqualfor-loops — avoids closure overhead in hot equality checksintersection,unique,$setDifference,$setEquals,$setIsSubsetcomputeExpression— operator-first check avoids iterating all keys; indexOf replaces split for prefix extractionprocessQuery,$exists💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.