Repository navigation
Tests: tilepopcheck scrolls to the Tile row - #328
Merged
Merged
Conversation
The 600 px case now uses --scroll-to @scene.tilebrushcell after Add, so a row added to the scene inspector no longer moves the Tile row off its mark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #327: the 600 px case reached the Tile row with a fixed 4-notch wheel after Add, which breaks the next time a row is added to the scene inspector. It now uses
--scroll-to @scene.tilebrushcell, which leaves the row at y 536-560; the old placement still opens the picker off screen there (563-795), so the check still fails without #327's fix.