Repository navigation
Standalone player: <Title>.exe on Windows, with the game's icon - #321
Merged
Merged
Conversation
Export Standalone Player on Windows now writes <Title>.exe instead of <Title>.bat (splashedit-ng#151): a copy of splashedit-player-launcher.exe (tools/player_launcher, a small Win32 GUI program shipped beside splashedit.exe) that reads config/launch.txt and starts pcsx-redux in kiosk mode with quoted full paths, or says in a message box what is missing. splash::setExeIcon gives it the memory card icon's first frame (16, 32 and 48 pixel images in icon group 1), keeping the launcher's other resources. Without the launcher beside the editor or CLI the .bat is written, with a warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of #151. On Windows, Export Standalone Player now writes
<Title>.exe. It is a copy of a small launcher (tools/player_launcher, built and shipped besidesplashedit.exe) that readsconfig/launch.txtand starts pcsx-redux in kiosk mode.splash::setExeIcongives it the memory card icon's first frame at 16, 32 and 48 pixels. When the launcher is missing, the.batis still written, with a warning.Checked on Linux, and under wine with a mingw build: the icon read back, and a folder path with spaces and accents launched correctly. The MSVC target and the Windows-only test get their first run in this PR's CI.