Test the image replacement path - #78
Merged
Merged
Conversation
file_utils' Data/ branch had no coverage at all, which is how Image.ANTIALIAS survived there for two years after Pillow 10.0 removed it: every user's image replacement raised AttributeError and nothing in CI noticed. #59 fixed the call but added no test, so the same class of breakage would go unnoticed again. These drive the real path against tests/data/table.key - matching assets are rewritten, the replacement is scaled down to each original variant, the source format is preserved, a non-matching pattern leaves the assets alone, and the result is still a readable Keynote archive rather than merely a valid zip. Verified the tests actually catch the bug they exist for: reintroducing Image.ANTIALIAS fails four of the five. Coverage of keynote_parser/file_utils.py goes from 40% to 67%. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0179M4xvAKPGrgKpy4AeCsM7
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.