Skip to content

ci: checkout before paths-filter so push-to-main runs pass - #35

Merged
psimaker merged 1 commit into
mainfrom
fix/ci-detect-changes-checkout
Jun 3, 2026
Merged

ci: checkout before paths-filter so push-to-main runs pass#35
psimaker merged 1 commit into
mainfrom
fix/ci-detect-changes-checkout

Conversation

@psimaker

@psimaker psimaker commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Problem

The CI run for the merge of #34 to main failed in the Detect changes job:


[command]/usr/bin/git branch --show-current
fatal: not a git repository (or any of the parent directories): .git
The process '/usr/bin/git' failed with exit code 128

Cause

The changes job ran dorny/paths-filter@v3 without a checkout. That is fine on pull_request events, where paths-filter lists changed files via the GitHub API. But on push events (the merge to main) there is no PR to query, so it falls back to a local git diff and needs a working copy. With no .git present, its first git command fails with exit code 128.

This surfaced only after merge: #34 introduced the changes job itself, and push-to-main was the first push event to exercise it. The PR checks passed because they ran on pull_request.

Fix

Add actions/checkout@v6 as the first step of the changes job so it works on both push and pull_request. Also updated the now-misleading comment.

Impact

  • Required checks (Go Tests, Notify Tests, Design Token Lint) were already green, so branch protection was never blocked.
  • The macOS Build & Test job was wrongly skipped on the failing run; with the checkout in place it is gated correctly again.

The Detect changes job ran dorny/paths-filter without a checkout. On
pull_request events that is fine — it lists changed files via the GitHub
API. But on push events (the merge of #34 to main) there is no PR to
query, so paths-filter falls back to a local git diff and needs a working
copy. With no .git present its first git command failed:

  fatal: not a git repository
  The process '/usr/bin/git' failed with exit code 128

This surfaced only after merge, since #34 introduced the job itself and
push-to-main was the first push event to exercise it. Add actions/checkout
as the first step so the job works on both push and pull_request.
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@psimaker, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 11 seconds. Learn how PR review limits work.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e7c04f50-007c-42b5-9008-e8d4a7fb135f

📥 Commits

Reviewing files that changed from the base of the PR and between 0857e6d and 2c4051d.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-detect-changes-checkout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@psimaker
psimaker merged commit 4861a72 into main Jun 3, 2026
13 checks passed
@psimaker
psimaker deleted the fix/ci-detect-changes-checkout branch June 3, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant