Repository navigation
Conversation
…result A dynamic-array formula whose input overlaps the area it spills into, such as =SORT(K16:O20) in H12 spilling over H12:L16, read its own previous spilled values when an edit recalculated it, so it sorted its old result into the new one. A full recalculation clears every spill first and reads those cells as empty, so the two disagreed: after K18=24, H12 showed 0 incrementally and 24 after a full recalculation. The command-sequence fuzzer found it (seed 107 at 200 seeds). While a formula is evaluated, the values its old spill left in the store are not there for it, or for the formulas it reads: cell_value and range_values read them as empty, as a full recalculation does. visit_range already leaves areas with spilled values to range_values. A new array computed in the same pass still reads as before. Test: a SORT over its own spill area, edited four times, agrees with a full recalculation after each edit (H12 was 0 instead of 24 before).
Owner
Author
|
@coderabbitai review |
|
Caution Review failedThe pull request is closed. Finishing Touches
Comment |
|
Owner
Author
|
Closed: the same bug is already addressed by an open upstream pull request with a broader fix, which also passes this branch's regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rehearsal of a fix before it is proposed upstream: one commit on the current upstream main. Not for merging.