chore(release): route release.yml through ci-tooling reusable @v0.4.2 - #1
Merged
Merged
Conversation
Replace inline release pipeline with caller of provide-io/ci-tooling/.github/workflows/python-release.yml@v0.4.2 and fix pre-existing mypy errors to unblock commit: - quality/profiling/profiler.py: remove unused type: ignore on None assignment - file/temp.py: silence import-untyped on optional yaml import - cli/testing.py: silence import-untyped on optional yaml import verify-testpypi uses importlib.metadata since provide.testkit has no __version__ attribute (matches the old smoke-test's intent but adds an assertion).
There was a problem hiding this comment.
Code Review
This pull request updates type hinting annotations across several files. Specifically, it adds type: ignore[import-untyped] to YAML imports in testing.py and temp.py to handle missing type stubs, and removes an unnecessary type: ignore[assignment] in profiler.py. I have no feedback to provide as there were no review comments.
livingstaccato
added a commit
that referenced
this pull request
May 3, 2026
…#1) Replace inline release pipeline with caller of provide-io/ci-tooling/.github/workflows/python-release.yml@v0.4.2 and fix pre-existing mypy errors to unblock commit: - quality/profiling/profiler.py: remove unused type: ignore on None assignment - file/temp.py: silence import-untyped on optional yaml import - cli/testing.py: silence import-untyped on optional yaml import verify-testpypi uses importlib.metadata since provide.testkit has no __version__ attribute (matches the old smoke-test's intent but adds an assertion).
livingstaccato
added a commit
that referenced
this pull request
May 4, 2026
…#1) Replace inline release pipeline with caller of provide-io/ci-tooling/.github/workflows/python-release.yml@v0.4.2 and fix pre-existing mypy errors to unblock commit: - quality/profiling/profiler.py: remove unused type: ignore on None assignment - file/temp.py: silence import-untyped on optional yaml import - cli/testing.py: silence import-untyped on optional yaml import verify-testpypi uses importlib.metadata since provide.testkit has no __version__ attribute (matches the old smoke-test's intent but adds an assertion).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches the wrknv / batch-1-3 rollout. Also fixes 3 pre-existing mypy errors to unblock commit (unused type-ignore and two import-untyped on optional PyYAML imports). verify-testpypi uses importlib.metadata since provide.testkit has no version.