[chore] Add automatic alt text for images in CKEditor fields - #301
Merged
Conversation
Collaborator
|
Does this do something for us, after all? |
Collaborator
Author
|
Yes! It wasn't working previously in this order: text // <img src="{asset:31382:url||/uploads/Prototypefund-7720.jpg}" />
|replace({
'/<div class="col-xs-24">/': "",
"/<\/div>$/": ""
}) // <img src="/uploads/Prototypefund-7720.jpg" />
|retconAutoAlt // no bueno, Retcon can't resolve asset from srcIt works correctly when text // <img src="{asset:31382:url||/uploads/Prototypefund-7720.jpg}" />
|retconAutoAlt // craft\elements\Asset
|replace({
'/<div class="col-xs-24">/': "",
"/<\/div>$/": ""
}) |
Collaborator
|
Oh, cool, good to know! That makes a lot of sense, actually. |
harryfk
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
tags.
retconAutoAltfilter when rendering CKEditor fields, which outputs each asset's alt text onNote: This filter must be called before any other filters that would serialize the field data. Serialization parses reference tags, preventing Retcon from locating the original asset to retrieve its alt text.