Refactoring and new Features - #180
Open
TitusLabs wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes klipper_z_calibration around three goals:
The runtime behavior of the normal calibration flow is intentionally kept close to the existing plugin:
CALIBRATE_Zstill measures nozzle, switch and bed positions, validates the calculated offset againstoffset_marginsand applies the result. The larger change is that Klipper/Kalico API access is now isolated behind compatibility helpers and covered by unit and firmware-contract tests.User-Visible Changes
offset_gcode.SET_GCODE_OFFSETbehavior.params.Zto the configured G-Code template.error_gcode.CALIBRATE_Zraises an error.params.ERROR.error_gcodeitself fails, that failure is logged without masking the original calibration error.max_deviationis replaced byoffset_margins.clearanceis replaced bysafe_z_height.How to Test
In the Moonraker config change the
primary_branchtotesting/z-calibration-refactorandchanneltodev:How to Revert
Remove the
primary_branchin the Moonraker config and change thechanneltostable.