Repository navigation
Fix dashboard post-process restart - #120
Merged
moodmosaic merged 1 commit intoSep 28, 2026
Merged
moodmosaic merged 1 commit into
moodmosaic merged 1 commit into
Conversation
Dashboard p treated any existing post container as running, so an exited post-process container could not be restarted from the TUI. Gate restart blocking on Docker state running, not container existence, and tell operators when an exited container will be replaced. Preserve the dashboard's active SWARM_CONFIG when invoking launch.sh post-process. Fixes protocol-security#110. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
This resolves #110. |
Member
|
Thank you, @aryaethn! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The credit for this bug and its fix goes entirely to @moodmosaic. I just coded his patch proposal from #110 to speed things up. Only small additions on top: two lines wrapped to 79 chars (the replacement notice now says "post-process container"), extra behavioural tests, and a stale
USAGE.mdline fixed.Summary
pnow refuses to start post-processing only when the post-process container is actually running, so an exited container no longer blocks a restart (fixes Dashboard post-process restart issue #110).psays it will be replaced;launch.sh post-processalready runsdocker rm -fon it before starting.ppasses the dashboard'sSWARM_CONFIGtolaunch.sh post-process, so dashboards opened with a non-default config launch the right post-process.P(logs) still works on an exited container, so a finished run's logs stay reachable.Changes
dashboard.sh: addpost_process_container_running; use it for thepguard and the[p]footer hint; print a replacement notice for exited containers; prefix the launch withSWARM_CONFIG="$CONFIG_FILE".tests/test_dashboard.sh: the static checks from Dashboard post-process restart issue #110, plus behavioural tests that load the realpost_process_container_exists/_runningfromdashboard.shwith a stubbedcontainer_stateacross running, exited, created, paused, not found, and none.USAGE.md: note thatpreplaces an exited run; fix the stale "Trigger via[P]" text, which has meant logs since the key swap in 85f60cd.CHANGELOG.md: entry under Unreleased.Test plan
./tests/test.sh --unit: 13 files, 1381 tests pass (macOS)./bin/bash tests/test_dashboard.shpasses under bash 3.2 (163 tests).dashboard.sh, 6 of the new checks fail, so they catch the bug.shellcheck -s bash --severity=warning dashboard.sh tests/test_dashboard.shis clean../tests/test.sh --all.s, thenp; it should warn that the previous container will be replaced and start a new run.SWARM_CONFIG=<non-default>.json, pressp; the post-process uses that config.The last three are unchecked because Docker wasn't available locally.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com