CI: pin Java to JDK 25 via actions/setup-java - #21
Merged
Conversation
The java-extraction test cases compile and run generated Java through bare javac/java calls, with no explicit toolchain selection, so CI was relying on whatever old default JDK happens to be on the runner PATH. Add an explicit Temurin 25 setup step, matching the JDK used locally. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
hiroshi-cl
commented
Jul 27, 2026
| uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: 'temurin' | ||
| java-version: '25' |
Author
There was a problem hiding this comment.
今までは指定されてなくてデフォで入ってたやつが使われてた
たぶん以下
- Linux: 17
- Mac: 21
cedretaber
approved these changes
Jul 27, 2026
Author
|
🙆♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
javac/javacalls intest-suite/misc/java-extraction/run-case.sh, with no explicit toolchain selection, so CI relied on whatever old default JDK happens to be on the runner PATH.actions/setup-java@v5step (Temurin, JDK 25) before the OCaml setup / test steps, matching the JDK used locally.Test plan
☕ Setup Javastep in both the macOS and Linux jobs resolves and installs Temurin 25.x🐛 Test Rocqstep still passes, including thejava-extractioncases (basic_arithmetic,list_reverse)🤖 Generated with Claude Code