Out of range panic fix#745
Open
artemseleznev wants to merge 1 commit into
Open
Conversation
Signed-off-by: Artem Seleznev <seleznyov.artyom@gmail.com>
artemseleznev
force-pushed
the
master
branch
from
fa2f422 to
411abf3
Compare
SuperQ
reviewed
Oct 21, 2025
SuperQ
left a comment
SuperQ
left a comment
Member
There was a problem hiding this comment.
There's definitely a corrupt input panic here. But do want to continue or error?
Member
|
It would also be useful to add some tests. |
Member
|
Yeah I feel we should error instead |
SuperQ
requested changes
Nov 12, 2025
SuperQ
left a comment
SuperQ
left a comment
Member
There was a problem hiding this comment.
This should return an error, not continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Svace static analyzer (https://www.ispras.ru/en/technologies/svace/) flagged this code as suspicious: it could lead to a panic (out of range) if len(out) == 0. It might happen if text would be e.g. "bla:bla"