Skip to content

Update node-exporter.md#3008

Open
hayakauwu wants to merge 1 commit into
prometheus:mainfrom
hayakauwu:main
Open

Update node-exporter.md#3008
hayakauwu wants to merge 1 commit into
prometheus:mainfrom
hayakauwu:main

Conversation

@hayakauwu

Copy link
Copy Markdown

add in example of simple systemd service to make node-exporter running 24/7

Reasoning being: i have used it along with Prometheus over the years and would have appreciated it being there when i was a newbie. If you feel the addition isn't relevant anymore, feel free to close.

add info quick systemd service to make node-exporter running 24/7

Signed-off-by: Hayaka <22380548+hayakauwu@users.noreply.github.com>

@jan--f jan--f left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I don't think we should add this particular change to the documentation. Systemd services should be written carefully and the one added here will likely not work well for most users.
Typically most users would probably look to their distributions package manager to install node-exporter, which will usually add a systemd service (or equivalent for the distros chosen init system). We should point user to their distros first and foremost.
Additionally we have example units in the node_exporter examples plus more for other init systems.

What we cloud do here is call out that the instructions run node_exporter in the foreground and users should look towards their distro packages for service units or use the one from the node_exporter repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants