Skip to content

[consul-exporter] Support using environment variables in command args #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javajawa wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

[consul-exporter] Support using environment variables in command args #6897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/prometheus-consul-exporter/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: v2
appVersion: "v0.13.0"
description: A Helm chart for the Prometheus Consul Exporter
name: prometheus-consul-exporter
version: 1.1.1
version: 1.2.0
keywords:
- metrics
- consul
Expand Down
7 changes: 7 additions & 0 deletions charts/prometheus-consul-exporter/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,16 @@ spec:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
{{- if .Values.invokeViaShell }}
command: ["/bin/sh"]
args:
- "-c"
- "consul_exporter --consul.server={{ .Values.consulServer }}"
{{- else }}
command: ["consul_exporter"]
args:
- "--consul.server={{ .Values.consulServer }}"
{{ end }}
{{- range $key, $value := .Values.options }}
- "--{{ $key }}{{ if $value }}={{ $value }}{{ end }}"
{{- end }}
Expand Down
6 changes: 6 additions & 0 deletions charts/prometheus-consul-exporter/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,12 @@ options: {}
# no-consul.health-summary:
# kv.filter=foobar

# By default, consul_exporter is run directly.
# If you want to use environment variables in `options` or `consulServer`,
# enable this option to have a shell interpret the command string before
# `consul_exporter` is executed.
invokeViaShell: false

service:
type: ClusterIP
port: 9107
Expand Down