Add cluster label to SLM metrics - #1239
Open
locker95 wants to merge 1 commit into
Open
Conversation
Resolve the cluster name through the UpdateContext introduced in prometheus-community#1052 and attach it as a "cluster" label to all slm_stats metrics, so SLM metrics from multiple clusters can be told apart. Fixes prometheus-community#889 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
clusterlabel (the cluster name) to allelasticsearch_slm_stats_*metrics, making SLM metrics distinguishable when scraping multiple clusters.It supersedes #1046 — thanks to @rneuter for the original work there. That PR predates #1052; this one instead builds on the
UpdateContext.GetClusterInfoAPI introduced there, as one of its first consumers: the cluster name is resolved once at the start ofUpdateand appended to the existing metric labels, following the same pattern as the snapshots collector change proposed for #629.The shared test mock now returns a fixed cluster name (
test-cluster), and the SLM test asserts the label on every metric.Fixes #889