Refactor indices_settings collector - #1181
Open
sysadmind wants to merge 1 commit into
Open
Conversation
- Move metric Desc to package vars - Use new COllector interface - Collapse response struct into the indices_settings.go file - Consolidate HTTP code into the Update() function Signed-off-by: Joe Adams <github@joeadams.io>
ArthurSens
reviewed
Jun 10, 2026
ArthurSens
left a comment
ArthurSens
left a comment
Contributor
There was a problem hiding this comment.
I believe README also needs to be updated with the new flag. And what is the plan with the current es.indices flag?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests haven't changed - this is a refactor only.