Fix duplicate index throttling metric registration - #1171
Open
wdtte wants to merge 1 commit into
Open
Conversation
Signed-off-by: yanxin <yanx10594@fxiaoke.com>
wdtte
force-pushed
the
fix/index-stats-is-throttled-conflict
branch
from
May 26, 2026 13:22
5090a10 to
027560b
Compare
Author
|
This PR is ready for review. It fixes a reproducible The change is intentionally small:
DCO is green now. A maintainer review would be appreciated. @sysadmind could you please take a look when you have time? This seems to be a regression caused by the interaction between multi-target If this is merged, an updated official image would be very helpful, since I am currently hitting this issue in production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
elasticsearch_index_stats_indexing_is_throttledelasticsearch_indices_indexing_is_throttledmetricNewNodesandNewIndicescan be registered togetherReproduction
The issue was reproduced in multi-target
/probemode with these flags:--es.uri=--config.file=/etc/elasticsearch-exporter/exporter-config.yml--web.listen-address=:9114--es.all--es.shards--es.ssl-skip-verifyRepresentative runtime logs:
The same panic repeats on every scrape while
NewNodes()andNewIndices()are both registered.Testing
env GOCACHE=/Users/wdte/GolandProjects/elasticsearch_exporter/.gocache go test ./collector -run TestNodesAndIndicesRegisterTogether -count=1Notes
go test ./collector/...is blocked in the current sandbox because existing tests usehttptest.NewServerand local port binding is not permitted in this environment