fix: prevent UI proxy session load hangs#442
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses UI dev proxy hangs by reducing background SSE pressure and improving proxy request handling for aborted clients and forwarded headers.
Changes:
- Limits inactive-project global event SSE connections to a maximum of 16.
- Removes selected forwarded request headers in the dev API proxy.
- Propagates client abort signals to upstream dev proxy fetches.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
app-prefixable/src/context/global-events.tsx |
Adds a cap on background global event connections for inactive projects. |
app-prefixable/dev.ts |
Updates dev API proxy request forwarding headers and abort handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diagnosis
The OpenCode backend continued to answer /session directly, but the UI dev proxy hung on /session and /api/session. The UI server process had many established backend connections, consistent with accumulated background SSE proxy connections. Restarting the UI server clears those sockets, which explains the observed workaround.
Verification