Set /128 suffix in single-address IPv6 CIDR - #174
Merged
Conversation
Neo - PR Security ReviewNo security issues found Highlights
Hardening Notes
Comment |
Mzack9999
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
asCidr()helper in networkpolicy.go unconditionally appended a /32 suffix to bare IP addresses. This is correct for IPv4 but invalid for IPv6, where the single-host prefix length is /128.asCidr()now parses the address to determine its family before appending the suffix (/32 for IPv4, /128 for IPv6). If parsing fails, the original string is passed through tonetip.ParsePrefix, which will surface the error as before.