Document R8 / full-mode minification safety in README#9
Merged
Conversation
Add an R8 / ProGuard / Minification section explaining that PrefsHelper needs no consumer keep rules: preference keys are explicit string args, never derived from property names via reflection, so renaming/merging is safe. Enum values are stored by Enum.name, preserved by R8's default Android rules. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an R8 / ProGuard / Minification section to the README documenting that PrefsHelper needs no consumer keep rules.
Why
While enabling R8 full-mode on a consuming app (AIM Capture), it built and ran with zero PrefsHelper keep rules. This documents why that's safe by design:
*Pref(...)delegates — never derived from Kotlin property names via reflection, so R8 renaming/merging/repackaging can't change a persisted key.enumConstants; enum values are stored byEnum.name(preserved by R8's default Android rules).Claims verified against the actual source before writing.
Release
Docs-only — no release needed.
🤖 Generated with Claude Code