Feature/get rid of node watcher#428
Merged
Merged
Conversation
hedibouattour
force-pushed
the
feature/get-rid-of-node-watcher
branch
from
September 21, 2022 16:21
dad125d to
90c970b
Compare
hedibouattour
force-pushed
the
feature/get-rid-of-node-watcher
branch
from
October 3, 2022 15:35
90c970b to
a47178e
Compare
sknat
reviewed
Oct 7, 2022
sknat
left a comment
sknat
left a comment
Collaborator
There was a problem hiding this comment.
That looks neat, thanks !
Just a few things, inline 😄
hedibouattour
force-pushed
the
feature/get-rid-of-node-watcher
branch
from
October 12, 2022 15:42
a47178e to
05b207f
Compare
hedibouattour
commented
Oct 12, 2022
hedibouattour
force-pushed
the
feature/get-rid-of-node-watcher
branch
from
October 12, 2022 15:50
05b207f to
fc5cec6
Compare
sknat
reviewed
Oct 13, 2022
hedibouattour
force-pushed
the
feature/get-rid-of-node-watcher
branch
4 times, most recently
from
October 18, 2022 08:50
e6e0cb9 to
a1e1a1b
Compare
sknat
reviewed
Oct 18, 2022
sknat
left a comment
sknat
left a comment
Collaborator
There was a problem hiding this comment.
Threading model looks neat !
Just a few nitpicks 😄
hedibouattour
force-pushed
the
feature/get-rid-of-node-watcher
branch
from
October 19, 2022 09:06
a1e1a1b to
3f06e62
Compare
sknat
approved these changes
Oct 19, 2022
hedibouattour
force-pushed
the
feature/get-rid-of-node-watcher
branch
2 times, most recently
from
December 1, 2022 16:43
4b49394 to
ac2f070
Compare
hedibouattour
force-pushed
the
feature/get-rid-of-node-watcher
branch
from
December 9, 2022 18:43
ac2f070 to
f78f869
Compare
sknat
approved these changes
Dec 12, 2022
Comment on lines
+1136
to
+1137
| IPv4Address: ip4net, | ||
| IPv6Address: ip6net, |
Collaborator
There was a problem hiding this comment.
Shouldn't those two be net.IP instead of *net.IPNet ?
Collaborator
Author
There was a problem hiding this comment.
@sknat this is used in getProviderType in connectivity server to know if it isCrossSubnet or not, that's why it is an IPNet
Collaborator
There was a problem hiding this comment.
Right, but from
ip, ip4net, err := net.ParseCIDR(msg.Ipv4Addr + "/32")we don't have a net.IPNet provided to us no ?
Collaborator
There was a problem hiding this comment.
hedibouattour
force-pushed
the
feature/get-rid-of-node-watcher
branch
2 times, most recently
from
December 13, 2022 16:00
b7e00fc to
b635e08
Compare
hedibouattour
force-pushed
the
feature/get-rid-of-node-watcher
branch
from
December 14, 2022 13:03
b635e08 to
a05ca3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on
[DEMO] calico-vpp/calico#10
✅ projectcalico/calico#6804
[PENDING ]projectcalico/calico#7090