Issue #872: Fix float overflow in plasma transition shader - #873
Merged
Conversation
2 tasks
blaquewithaq
approved these changes
Feb 28, 2025
github-project-automation
Bot
moved this from In Review
to Done
in libprojectM Release 4.2
kblaschke
deleted the
bugfix/872-dev-bug-broken-plasma-transition-on-nvidia-shield-number-overflow
branch
March 4, 2025 13:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On higher resolutiuons and when using GLES, the plasma transition shader could result in generating using huge numbers as input for
sin(), returning NaN as a result and breaking the shader output. Fixed by dividing each coordinate multiplier by 10.000.