Skip to content

Disable vcpkg applocal for static Windows builds #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thedavidweng wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable vcpkg applocal for static Windows builds #1023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/build_windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,12 @@ jobs:
run: |
if("${{ matrix.libs }}" -eq "shared") {
$shared_libs = "ON"
$applocal_deps = "ON"
} else {
$shared_libs = "OFF"
# Static triplets link everything (incl. CRT) statically, so there are no DLLs to deploy.
# Disabling applocal removes a proven file-lock race (MSB3073, exit 32) with zero benefit lost.
$applocal_deps = "OFF"
}
if("${{ matrix.fslib }}" -eq "boost") {
$use_boost = "ON"
Expand Down Expand Up @@ -100,6 +104,7 @@ jobs:
-DCMAKE_MSVC_RUNTIME_LIBRARY="MultiThreaded$<$<CONFIG:Debug>:Debug>$($runtime)" `
-DCMAKE_VERBOSE_MAKEFILE=YES `
-DBUILD_SHARED_LIBS="$($shared_libs)" `
-DVCPKG_APPLOCAL_DEPS="$($applocal_deps)" `
-DENABLE_BOOST_FILESYSTEM="$($use_boost)" `
-DENABLE_CXX_INTERFACE=YES `
-DBUILD_TESTING=YES `
Expand Down Expand Up @@ -133,9 +138,12 @@ jobs:
}
if("${{ matrix.libs }}" -eq "shared") {
$runtime = "DLL"
$applocal_deps = "ON"
} else {
$runtime = ""
$triplet = $triplet + "-static"
# Same as above: nothing to deploy for static builds, only file-lock risk.
$applocal_deps = "OFF"
}
if("${{ matrix.runs-on }}" -eq "windows-2022") {
$generator = "Visual Studio 17 2022"
Expand All @@ -151,6 +159,7 @@ jobs:
-DCMAKE_MSVC_RUNTIME_LIBRARY="MultiThreaded$<$<CONFIG:Debug>:Debug>$($runtime)" `
-DCMAKE_TOOLCHAIN_FILE="${Env:VCPKG_INSTALLATION_ROOT}/scripts/buildsystems/vcpkg.cmake" `
-DVCPKG_TARGET_TRIPLET="$($triplet)" `
-DVCPKG_APPLOCAL_DEPS="$($applocal_deps)" `
-DENABLE_BOOST_FILESYSTEM="$($use_boost)" `
-DCMAKE_VERBOSE_MAKEFILE=ON

Expand Down