Fix build metadata: vcpkg version and undefined summary variable - #1021
Merged
kblaschke merged 1 commit intoSep 3, 2026
Merged
Conversation
kblaschke
approved these changes
Sep 3, 2026
kblaschke
left a comment
kblaschke
left a comment
Member
There was a problem hiding this comment.
Makes total sense, I've totally missed to update the vcpkg manifest, which should help with local port overlays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small build-metadata fixes, no behavior change:
vcpkg.json: bumpversionfrom4.1.2to4.2.0to matchproject(libprojectM VERSION 4.2.0)inCMakeLists.txt. It was missed when the version was bumped.CMakeLists.txt: remove the configure-summary line printing${ENABLE_SHARED_LINKING}. That variable is never defined viaoption()anywhere in the tree and is not passed by CI, so the summary always printed an empty value.Verified with a clean macOS configure (
cmake -S . -B build): configuration succeeds and the summary no longer contains the empty line. Kept separate from any docs changes.