#SBCOSS-584: Removed hardcoded bmgs - #56
Merged
Merged
Conversation
…, medium, and subject
…ramework category parameters
…ervice helper for dynamic framework category handling
There was a problem hiding this comment.
Pull Request Overview
This PR removes hardcoded BMGS (Board, Medium, Grade, Subject) files from access path filtering and implements a Dynamic Category Manager that dynamically fetches framework categories based on channel ID. The changes enable parameterized reports to use dynamic validation rules instead of static configuration files.
- Implemented Dynamic Category Manager to fetch framework categories from channel and framework APIs
- Replaced hardcoded access path validation with dynamic category-based validation
- Updated report search and access validation to use async framework category parameters
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| helpers/envHelpers.js | Simplified debug require statement by removing hardcoded board parameter |
| helpers/dataServiceHelper.js | Added framework category parameter setup in exhaust dataset processing |
| controllers/report.js | Modified search and read operations to use async access validation with framework categories |
| controllers/parameters/index.js | Added setFrameworkCategoryParameters function to dynamically create parameters from framework data |
| controllers/accessPaths/index.js | Integrated dynamic category manager and updated validateAccessPath to handle async operations |
| controllers/accessPaths/dynamicCategoryManager.js | New module implementing dynamic framework category fetching |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.