Skip to content

#SBCOSS-584: Removed hardcoded bmgs - #56

Merged
manjudr merged 13 commits into
project-sunbird:release-8.0.0from
Rakshitha-D:testBMGS
Sep 12, 2025
Merged

#SBCOSS-584: Removed hardcoded bmgs#56
manjudr merged 13 commits into
project-sunbird:release-8.0.0from
Rakshitha-D:testBMGS

Conversation

@Rakshitha-D

@Rakshitha-D Rakshitha-D commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator
  1. Removed the BMGS file from the access path that was previously used for filtering.
  2. Implemented a Dynamic Category Manager that leverages the channel ID to fetch framework categories and generate validation rules for the access path.
  3. Configured framework categories as dynamic parameters, which are then utilised in the APIs to verify parameterised reports.

@manjudr
manjudr requested a review from Copilot September 11, 2025 05:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes hardcoded BMGS (Board, Medium, Grade, Subject) files from access path filtering and implements a Dynamic Category Manager that dynamically fetches framework categories based on channel ID. The changes enable parameterized reports to use dynamic validation rules instead of static configuration files.

  • Implemented Dynamic Category Manager to fetch framework categories from channel and framework APIs
  • Replaced hardcoded access path validation with dynamic category-based validation
  • Updated report search and access validation to use async framework category parameters

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
helpers/envHelpers.js Simplified debug require statement by removing hardcoded board parameter
helpers/dataServiceHelper.js Added framework category parameter setup in exhaust dataset processing
controllers/report.js Modified search and read operations to use async access validation with framework categories
controllers/parameters/index.js Added setFrameworkCategoryParameters function to dynamically create parameters from framework data
controllers/accessPaths/index.js Integrated dynamic category manager and updated validateAccessPath to handle async operations
controllers/accessPaths/dynamicCategoryManager.js New module implementing dynamic framework category fetching

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread controllers/parameters/index.js Outdated
Comment thread controllers/parameters/index.js Outdated
Comment thread controllers/parameters/index.js Outdated
Comment thread controllers/accessPaths/index.js
Comment thread controllers/accessPaths/index.js Outdated
Comment thread controllers/report.js
Comment thread controllers/report.js Outdated
Comment thread controllers/report.js Outdated
@manjudr
manjudr merged commit ea97f3a into project-sunbird:release-8.0.0 Sep 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants