Skip to content

sb25716 fix: accessibility hide navigation from device dequee-560441 #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sachinsahu731 wants to merge 1 commit into
base: release-4.2.0
Choose a base branch
from
Open

sb25716 fix: accessibility hide navigation from device dequee-560441 #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions projects/sunbird-player-sdk/src/lib/core/components/sidebar/sidebar.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
<div class="navBlock">
<div class="player-nav-unit text-left" role="heading" aria-level="2">{{title}}</div>
<ul role="navigation" aria-label="player sidebar">
<li *ngIf="config.showShare" role="button" tabindex="0" (click)="sidebarEvent.emit('SHARE')"><span class="player-icon player-share mr-16"></span> Share</li>
<li *ngIf="config.showDownload" role="button" tabindex="0" (click)="showDownloadPopup()"><span class="player-icon player-download mr-16"></span> Download</li>
<li *ngIf="config.showPrint" role="button" tabindex="0" (click)="sidebarEvent.emit('PRINT')"><span class="player-icon player-print mr-16"></span> Print</li>
<li *ngIf="config.showExit" role="button" tabindex="0" (click)="sidebarEvent.emit('EXIT');closeNav();"><span class="player-icon player-exit mr-16"></span> Exit</li>
<li *ngIf="config.showShare" role="button" tabindex="0" (click)="sidebarEvent.emit('SHARE')"><span class="player-icon player-share mr-16" aria-hidden="true"></span> Share</li>
<li *ngIf="config.showDownload" role="button" tabindex="0" (click)="showDownloadPopup()"><span class="player-icon player-download mr-16" aria-hidden="true"></span> Download</li>
<li *ngIf="config.showPrint" role="button" tabindex="0" (click)="sidebarEvent.emit('PRINT')"><span class="player-icon player-print mr-16" aria-hidden="true"></span> Print</li>
<li *ngIf="config.showExit" role="button" tabindex="0" (click)="sidebarEvent.emit('EXIT');closeNav();"><span class="player-icon player-exit mr-16" aria-hidden="true"></span> Exit</li>
</ul>
</div>
<div class="transparentBlock" tabindex="0" role="button" (click)="closeNav()"></div>
Expand Down