Skip to content

fix: use defined typedefs in defining app_entry#57

Merged
NikhilNarayana merged 1 commit into
project-slippi:slippifrom
Savestate2A03:bug/app_entry
Mar 28, 2026
Merged

fix: use defined typedefs in defining app_entry#57
NikhilNarayana merged 1 commit into
project-slippi:slippifrom
Savestate2A03:bug/app_entry

Conversation

@Savestate2A03

Copy link
Copy Markdown

Addresses this issue with types not being correct:

rei wolf@DESKTOP-8JOF1RA MSYS /c/dev/Nintendont
$ ./'Incremental Build.bat'

C:\dev\Nintendont>make all windows=1

Building Multi-DOL loader

make -C multidol
make[1]: Entering directory '/c/dev/Nintendont/multidol'
 ASSEMBLE    crt0.S
 COMPILE     cache.c
 COMPILE     main.c
 COMPILE     global.c
 COMPILE     apploader.c
apploader.c: In function 'Apploader_Run':
apploader.c:118:36: error: passing argument 2 of 'appldr_entry' from incompatible pointer type [-Wincompatible-pointer-types]
  118 |         appldr_entry(&appldr_init, &appldr_main, &appldr_final);
      |                                    ^~~~~~~~~~~~
      |                                    |
      |                                    int (**)(char **, u32 *, u32 *) {aka int (**)(char **, unsigned int *, unsigned int *)}
apploader.c:118:36: note: expected 'int (**)(void)' but argument is of type 'int (**)(char **, u32 *, u32 *)' {aka 'int (**)(char **, unsigned int *, unsigned int *)'}
make[1]: *** [Makefile:40: apploader.o] Error 1
make[1]: Leaving directory '/c/dev/Nintendont/multidol'
make: *** [Makefile:34: multidol] Error 2

If I'm missing anything feel free to comment.

sticks-stuff added a commit to sticks-stuff/Nintendont that referenced this pull request Sep 30, 2025
@NikhilNarayana NikhilNarayana changed the title Use defined typedefs in defining app_entry fix: use defined typedefs in defining app_entry Mar 28, 2026
@NikhilNarayana NikhilNarayana merged commit fd450c7 into project-slippi:slippi Mar 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants