Use new Makepad support for more image formats, fix rotation, show SVGs as images#913
Merged
kevinaboos merged 3 commits intoJun 7, 2026
Merged
Conversation
…Gs as images We can now display png, jpg, gif, webp, bmp, ico, qoi, svg, which covers the vast majority of image formats encountered in the wild in Matrix rooms. Note that we already had SVG support,ngs like icons, it just wasn't included in the main `Image` widget. My changes to makepad make it easy to auto-detect and load any image format, so there's no need for complex PNG- or JPG-specific code with fallbacks. All of that's been moved into makepad's Image widget. Fix the ImageViewer to support SVGs, and fix its image rotation for images that don't have a square aspec ratio, with a neat little animation. Plus, now we don't need the dependency on the big `image` crate.
kevinaboos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can now display png, jpg, gif, webp, bmp, ico, qoi, svg, which covers the vast majority of image formats encountered in the wild in Matrix rooms. Note that we already had SVG support,ngs like icons, it just wasn't included in the main
Imagewidget.My changes to makepad make it easy to auto-detect and load any image format, so there's no need for complex PNG- or JPG-specific code with fallbacks. All of that's been moved into makepad's Image widget.
Fix the ImageViewer to support SVGs, and fix its image rotation for images that don't have a square aspec ratio, with a neat little animation.
Plus, now we don't need the dependency on the big
imagecrate.