Conversation
✅ Deploy Preview for shiny-selkie-5e063f canceled.
|
Author
|
Hi .. can any maintainer pull in this ?? |
|
its been a bit since any maintainer was active |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SeClientassumedchart.wwalways existedIn night-vision/src/core/se/seClient.js, the constructor did
this.ww = chart.wwunconditionally. ButDataHubcan requestSeClient.instance(id)before the full chart object is attached, which caused the runtime crash:Cannot read properties of undefined (reading 'ww')Fix:
SeClienttolerate missingchartshowLogosetter wrote to the wrong fieldIn night-vision/src/interface.js, the setter was:
So changing
showLogoactually overwrote the componentid, which is a real bug and can corrupt internal chart identity/state.Fix:
this.comp.$set({showLogo: val})MetaHub.finish()triggered an unsafe deferred layout refreshIn night-vision/src/core/metaHub.js,
finish()did a delayed:update-layoutupdate-legendThat extra deferred refresh could run while the chart was still between data/layout states, which contributed to crashes like:
Cannot read properties of undefined (reading '0')Cannot read properties of undefined (reading 'Candles')Fix:
finish()