Remove unused Performance Tests feature - #328
Merged
Merged
Conversation
- Delete test_collections/matter/sdk_tests/support/performance_tests/ folder
(test collection, models, scripts — 13 files)
- Remove sdk_performance_collection import from test_collections/matter/__init__.py
- Remove STRESS_TEST_COLLECTION import and pop() call from pics_applicable_test_cases.py
- Remove create_summary_report import and POST /{id}/performance_summary endpoint
from app/api/api_v1/endpoints/test_run_executions.py
- Remove Performance Test Suite special-case branches and TestStep import
from app/test_engine/test_script_manager.py
- Remove stress test script path constants and volume mounts from sdk_container.py
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the SDK Performance and Stress Tests collection, including its endpoints, test cases, suites, parser, and related Docker container volume mounts. Feedback on the changes includes addressing an indentation issue in app/test_engine/test_script_manager.py where the body of a for loop is over-indented following the removal of an if-else block.
| else: | ||
| for test_case_execution in test_case_executions: | ||
| for test_case_execution in test_case_executions: | ||
| # TODO: request correct TestCase from TestScriptManager |
Contributor
There was a problem hiding this comment.
The body of the for loop (lines 326 to 336) is over-indented by 4 spaces. It should be unindented to align with the standard 4-space indentation level under the for statement, in accordance with PEP 8.
References
- PEP 8 recommends using 4 spaces per indentation level. (link)
oxesoft
approved these changes
Jun 2, 2026
oxesoft
pushed a commit
that referenced
this pull request
Jun 2, 2026
- Delete test_collections/matter/sdk_tests/support/performance_tests/ folder
(test collection, models, scripts — 13 files)
- Remove sdk_performance_collection import from test_collections/matter/__init__.py
- Remove STRESS_TEST_COLLECTION import and pop() call from pics_applicable_test_cases.py
- Remove create_summary_report import and POST /{id}/performance_summary endpoint
from app/api/api_v1/endpoints/test_run_executions.py
- Remove Performance Test Suite special-case branches and TestStep import
from app/test_engine/test_script_manager.py
- Remove stress test script path constants and volume mounts from sdk_container.py
Contributor
|
Cherry-picked to v2.16-develop |
This was referenced Jun 2, 2026
Closed
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unused Performance Tests feature from the backend. This feature was built but never adopted by users, leaving a significant amount of dead
code in the codebase.
Motivation
The Performance Tests feature was implemented but is not being used by users in production. Keeping it adds unnecessary maintenance burden, increases cognitive overhead when reading the codebase, and adds dead volume mounts to every SDK container startup. Removing it reduces the codebase by ~2,044 lines.
Impact
Related Issue
#1014
Testing
All unit tests runs successfully
TH runs successfully