Skip to content

[Fix] Prefer operational_dataset_hex over live OTBR dataset in ThreadAutoConfig #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rquidute merged 1 commit into from
May 28, 2026
Merged

[Fix] Prefer operational_dataset_hex over live OTBR dataset in ThreadAutoConfig #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/schemas/test_environment_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class ThreadAutoConfig(BaseModel):
otbr_docker_image: Optional[str]
ba_host: Optional[str] = None
ba_port: Optional[int] = None
operational_dataset_hex: Optional[str] = None


class TestEnvironmentConfigError(Exception):
Expand Down
17 changes: 10 additions & 7 deletions test_collections/matter/sdk_tests/support/python_testing/models/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,15 +274,18 @@ async def __thread_dataset_hex(
if isinstance(thread_config, ThreadExternalConfig):
hex_dataset = thread_config.operational_dataset_hex
elif isinstance(thread_config, ThreadAutoConfig):
border_router: ThreadBorderRouter = ThreadBorderRouter()
if thread_config.operational_dataset_hex:
hex_dataset = thread_config.operational_dataset_hex
else:
border_router: ThreadBorderRouter = ThreadBorderRouter()

# Expecting false as the OTBR is started in the suite's setup.
# Either way, if true, we try to start and configure the container in case
# there's no OTBR application running.
if await border_router.start_device(thread_config):
await border_router.form_thread_topology()
# Expecting false as the OTBR is started in the suite's setup.
# Either way, if true, we try to start and configure the container in case
# there's no OTBR application running.
if await border_router.start_device(thread_config):
await border_router.form_thread_topology()

hex_dataset = border_router.active_dataset
hex_dataset = border_router.active_dataset
Comment thread
rquidute marked this conversation as resolved.

return hex_dataset

Expand Down
Loading