Rename python testing suite names - #314
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the "Python Testing Suite" and its variants to "Python Testing Suite - Auto commissioning" and "Python Testing Suite - No auto commissioning" across database migrations, suite declarations, and unit tests. Feedback on the new Alembic migration script suggests refactoring the upgrade and downgrade logic into loops for better maintainability and ensuring that the metadata table is updated before the execution table to prevent potential foreign key constraint issues.
antonio-amjr
approved these changes
May 19, 2026
oxesoft
approved these changes
May 20, 2026
…n_suite_commissioning_.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the Python Testing Suite categories to use clearer, more descriptive names that better reflect what each suite actually does. Adds a database migration to update
existing test run execution records so that historical data remains intact after the rename.
Changes
Both the plain and -custom suffixed variants are covered.
test_sdk_python_collection.py — Updated test assertions to reference the new suite names.
alembic/versions/b1f9e3d7c2a5_rename_python_suite_commissioning_.py — New Alembic migration that updates testsuiteexecution.public_id and testsuitemetadata.public_id / title /
description for all affected rows, including -custom variants. A downgrade() path is included to revert the rename if needed.
Motivation
The original names were ambiguous — "Python Testing Suite" gave no indication that commissioning was involved, and "No commissioning" was easy to misread as "nothing was commissioned yet" rather than "commissioning is handled externally." The new names ("Auto commissioning" / "No auto commissioning") make the distinction explicit and consistent with the language used elsewhere in the tool.
Without the migration, the left panel in the UI would appear empty for any existing test run execution, because the frontend and backend use the suite public_id as a key to reconstruct execution state, and the DB would still hold the old names.
Impact
Related Issue
project-chip/certification-tool#978
Testing
Unit tests were updated and they are all passing
UI displays the renamed Python suites