[Feature] Make NFC_Reader_index default 0 - #311
Merged
oxesoft merged 9 commits intoMay 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the handling of NFC pairing modes by making discriminator and setup code optional and injecting a default NFC reader index into command arguments. Feedback highlights a potential crash and side-effect in the parameter injection logic, a missing f-string prefix in a validation error message, and an inconsistency where the reader index injection is missing from performance tests.
rquidute
changed the base branch from
v2.15-develop
to
fix/977_fix_nfc_validation_setup_code_and_discriminator
May 5, 2026 21:48
OlivierGre
approved these changes
May 6, 2026
antonio-amjr
approved these changes
May 13, 2026
Base automatically changed from
fix/977_fix_nfc_validation_setup_code_and_discriminator
to
v2.16-develop
May 26, 2026 11:53
oxesoft
approved these changes
May 26, 2026
…_when_not_informed # Conflicts: # test_collections/matter/sdk_tests/support/performance_tests/models/utils.py # test_collections/matter/sdk_tests/support/python_testing/models/utils.py # test_collections/matter/sdk_tests/support/tests/yaml_tests/test_matter_yaml_runner.py # test_collections/matter/sdk_tests/support/yaml_tests/models/chip_suite.py
oxesoft
deleted the
feature/980_default_0_index_NFC_reader_index_when_not_informed
branch
May 26, 2026 17:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Adds support for automatically defaulting NFC_Reader_index to 0 when not explicitly provided in test_parameters for NFC pairing modes (nfc-wifi and nfc-thread). This removes the need for users to always specify the reader index when a single NFC reader is in use.
Motivation
The SDK runner requires NFC_Reader_index to be present in global_test_params when using NFC commissioning. Most setups use a single NFC reader (index 0), so requiring users to always pass this parameter explicitly adds unnecessary friction. This feature makes index 0 the implicit default, allowing NFC tests to run out of the box without extra configuration.
Impact
Changes
test_collections/matter/sdk_tests/support/python_testing/models/utils.py
test_collections/matter/sdk_tests/support/tests/python_tests/test_utils.py
Related Issue
project-chip/certification-tool#980
Testing
Unit tests added and all passing
Run a test execution with no NFC_Reader_index informed and the TH send command with --int-arg NFC_Reader_index:0