Skip to content

Remove commissioning prompt from no commissioning tests #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rquidute merged 3 commits into from
Apr 24, 2026
Merged

Remove commissioning prompt from no commissioning tests #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7e23d8
Remove commissioning prompt from no commissioning suite
rquidute Apr 24, 2026
f43c74b
Fix mypy
rquidute Apr 24, 2026
622b367
Code review
rquidute Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions test_collections/matter/sdk_tests/support/python_testing/models/test_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,19 +663,16 @@ def __evaluate_user_response_for_errors(
class NoCommissioningPythonTestCase(PythonTestCase):
async def setup(self) -> None:
await super().setup()
Comment thread
rquidute marked this conversation as resolved.
user_response = await prompt_for_commissioning_mode(
self, logger, None, self.cancel
)
if user_response == PromptOption.FAIL:
raise DUTCommissioningError(
"User chose prompt option FAILED for DUT is in Commissioning Mode"
)

logger.info("Setup - No Commissioning Python Test Case")


class LegacyPythonTestCase(PythonTestCase):
async def setup(self) -> None:
await super().setup()

logger.info("Setup - Legacy Python Test Case")

await self.prompt_about_commissioning()

async def prompt_about_commissioning(self) -> None:
Expand Down
33 changes: 32 additions & 1 deletion test_collections/matter/sdk_tests/support/tests/python_tests/test_python_test_case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@
from ...models.matter_test_models import MatterTestStep, MatterTestType
from ...python_testing.models import PythonTestCase
from ...python_testing.models.python_test_models import PythonTest, PythonTestType
from ...python_testing.models.test_case import LegacyPythonTestCase
from ...python_testing.models.test_case import (
LegacyPythonTestCase,
NoCommissioningPythonTestCase,
)
from ...python_testing.models.utils import DUTCommissioningError
from ...utils import PromptOption

Expand Down Expand Up @@ -507,3 +510,31 @@ async def test_legacy_python_test_case_new_commissioning() -> None:

mock_prompt_commissioning.assert_called_once()
mock_commission_device.assert_called()


@pytest.mark.asyncio
async def test_no_commissioning_python_test_case_does_not_prompt_commissioning_mode() -> None:
"""Test that NoCommissioningPythonTestCase.setup() does not prompt the user to put
the DUT in commissioning mode.

Regression test for: TC_DD_1_5 showing spurious commissioning prompt when run via CLI.
"""
test_case_execution = TestCaseExecution()
test = python_test_instance(
name="TC-DD-1.5",
path=Path("path"),
python_test_type=PythonTestType.NO_COMMISSIONING,
)

test_case = NoCommissioningPythonTestCase.class_factory( # type: ignore
test=test,
python_test_version="version",
mandatory=False,
)(test_case_execution)

with mock.patch(
"test_collections.matter.sdk_tests.support.python_testing.models.test_case"
".prompt_for_commissioning_mode"
) as mock_prompt_commissioning:
await test_case.setup()
mock_prompt_commissioning.assert_not_called()
Loading