Adding nfc-wifi to the backend rebased to V2.15-develop - #294
Merged
rquidute merged 10 commits intoFeb 19, 2026
Conversation
Contributor
Summary of ChangesHello @ArnoldBraine, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for a new NFC-WIFI device pairing mode across the backend system. The changes involve updating core constants, modifying setup procedures to accommodate NFC-specific hardware interactions, and extending utility functions to handle WiFi network credentials for this new mode. Additionally, the YAML test runner has been enhanced with a dedicated method for NFC-WIFI pairing, accompanied by new test cases to ensure the functionality is correctly implemented and validated. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully adds support for the nfc-wifi pairing mode. The changes are consistent with the existing codebase, and it's great to see that new tests have been added to cover this new functionality. My review includes a few suggestions to improve code readability and reduce duplication. Specifically, I've recommended using the in operator for membership testing and pointed out opportunities to use pytest.mark.parametrize to consolidate similar test cases, which will enhance maintainability.
| ] == arguments | ||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_generate_command_arguments_nfc_wifi() -> None: |
Contributor
There was a problem hiding this comment.
This new test, test_generate_command_arguments_nfc_wifi, is nearly identical to the existing test_generate_command_arguments_ble_wifi. To avoid code duplication and improve maintainability, I recommend using pytest.mark.parametrize to combine these into a single parameterized test. This would make it easier to add and test other Wi-Fi based pairing modes in the future.
| chip_server._ChipServer__node_id = None | ||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_pairing_nfc_wifi_command_params() -> None: |
Contributor
There was a problem hiding this comment.
The new test test_pairing_nfc_wifi_command_params is very similar to test_pairing_ble_wifi_command_params. To reduce code duplication and make the test suite more maintainable, consider using pytest.mark.parametrize to create a single, parameterized test function that can handle various Wi-Fi pairing modes.
| discriminator=self.config_matter.dut_config.discriminator, | ||
| ) | ||
|
|
||
| async def __pair_with_dut_nfc_wifi(self) -> bool: |
Contributor
There was a problem hiding this comment.
The new method __pair_with_dut_nfc_wifi is almost identical to __pair_with_dut_ble_wifi and __pair_with_dut_wifipaf_wifi. This introduces significant code duplication. To improve maintainability, consider refactoring these into a single private helper method that accepts the specific pairing function (e.g., self.runner.pairing_nfc_wifi) as an argument. This would centralize the logic for Wi-Fi pairing.
rquidute
requested review from
antonio-amjr,
ccruzagralopes,
hiltonlima,
oxesoft and
rquidute
February 4, 2026 18:29
rquidute
requested changes
Feb 5, 2026
Contributor
Author
I have updated the code according to the review, and with User Guide you are referring to the certfication-tool documentation right? |
Contributor
Exactly @ArnoldBraine |
rquidute
approved these changes
Feb 6, 2026
oxesoft
approved these changes
Feb 6, 2026
Contributor
|
Hi @ArnoldBraine It seems there are some comments from gemini-code-assist still not addressed, also a rebase is required. Could you please take a look? |
Contributor
Author
Hi @rquidute,
|
Contributor
Hi @ArnoldBraine |
antonio-amjr
approved these changes
Feb 13, 2026
oxesoft
added a commit
that referenced
this pull request
May 25, 2026
* Updated SDK SHA - revert * Changed SDK_DOCKER_TAG to f2e5de7_latest * Make all TH dependencies not static (#164) * Updated package-dependency-list.txt * Updated missing dependencies * [FIX] Reverting the OTBR Start Script (#150) * Reverting the BR_VARIANT option to the otbr start script * Adding TODO to the script * Adding missing comment char * Updating Script Comment Year Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Adding switch parameters options to the script --------- Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Do not error while parsing SDK python tests (#141) * replace erro with warning * Update test_collections/matter/sdk_tests/support/python_testing/models/python_test_parser.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * black error fix * pr review --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Add TC-IDM-10.5 test case to mandatory suite (#153) * Check user prompt answer FAILED for DUT commissioning (#155) * Handle Skip test fir old script python test cases (#154) * [FIX] Intermittent Tests Start Error With No Information (#157) * Fixing intermittent problem with Python's Base Manager Creating the manager now only once in the SDK Container Init * Refactoring and updating the unit tests with related mocks * Update python_testing references after SDK refactoring (#162) * Updated python_testing references after sdk refactoring * Removed no wanted file changes * Updated matter_testing references * Fixed line too long * Fixed code - black * Updated SDK SHA * Removed commented code * Revert "[FIX] Intermittent Tests Start Error With No Information (#157)" (#166) This reverts commit 316a934d45d94f177c3525d3d9cd8b6718e81014. * 01 - Isolate SDK docker pull script (#142) * Isolate SDK docker pull script * Changes after code review --------- Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> * 02 - Script to parser SDK python tests (#144) * Isolate SDK docker pull script * Rebasing * Apply suggestions from code review Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Move call tp update-pull-sdk-docker-image.sh from setup.sh to update-sample-apps.sh * Changes after code review * Fixed CI issues * Code review fixes * Fixed unit tests * Fixed mypy --------- Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> * Implemented changes for custom python test (#167) * Implemented changes for custom python test * code review * Code review * Code reviewd * Fixed code violations * Chanegs after code review * Remove unused import * Update update-sample-app script to copy apps from new origin (#148) * Fix suite names for custom python tests (#168) * Fix move update-pull-sdk-docker-image script content to update-sample-app script (#169) * Fixed some python tests not listed (#172) * Fixed some python tests not listed * code review * [Feature] Implement support to export project config (#171) * Implement support to export project config * Fix mypy * Changed the returned schema and service endpoint name * Added import project config * Apply suggestions from code review Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * code review --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * [FIX] Added support to negated PICS (#170) * Added support to negated PICS * Fixed flake * Code review. No consider negatives PICS * Update app/pics_applicable_test_cases.py * Code review * Fixes after merge * Remove unused file (#175) * Remove unused file * Updated cspell * Fix ci issues v 2 12 (#176) * Fix CI issues from v2.12 branch * Fixed merge * Fix test case * Updated SDK_DOCKER_IMAGE url * Updated SDK_DOCKER_IMAGE url * Add support for configuring terms and conditions in device commissioning (#173) * Add support for configuring terms and conditions in device commissioning This commit introduces a new `enhanced_setup_flow` configuration property to the test harness backend, allowing device manufacturers to define the terms and conditions (T&C) that must be acknowledged and set during device commissioning. These values are critical for supporting the Terms and Conditions Certification Test Suite. Key changes include: - Added the `EnhancedSetupFlowConfig` class to `DutConfig`, which allows specifying the T&C version and user response required during commissioning. - Updated `generate_command_arguments` in `utils.py` to append the necessary arguments for T&C validation and the device's commissioning method. - Adjusted model validation to ensure the `enhanced_setup_flow` field is processed correctly within `DutConfig`. These changes ensure the test harness can enforce manufacturer-specific T&C values during the commissioning process, aligning with the broader requirements of T&C validation. * * Ran ./scripts/format.sh * Update test_collections/matter/test_environment_config.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update app/user_prompt_support/uploaded_file_support.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/performance_tests/utils.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/models/utils.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/models/utils.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/__init__.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Revert changes to test_collections/matter/sdk_tests/support/performance_tests/utils.py * Restyle test_environment_config.py * test: Add in-test-commissioning-method parameter for manual commissioning validation Add new parameter to control commissioning flow during tests, allowing manual validation of the commissioning process instead of auto-commissioning. This enables test cases to verify terms and conditions acknowledgements during the commissioning flow. - Add in-test-commissioning-method parameter to test flags - Support manual commissioning flow validation - Enable testing of T&C acknowledgement scenarios * Add new field "enhanced_setup_flow" to exception message * Cherry-pick test_python_parser.py from origin/main * Cherry-pick python_test_parser.py from origin/main * Revert "Cherry-pick python_test_parser.py from origin/main" This reverts commit 5d65ce5c4fd8d8e6d67cad68ceea52b999f1dacd. * Revert "Cherry-pick test_python_parser.py from origin/main" This reverts commit 2cd99b7fde26e2d676a55c0b135d2618e89eda52. * Removed broken test `test_python_parser.py` * Revert "Removed broken test `test_python_parser.py`" This reverts commit 48c0e323bdaf8b07ba1b6e9dcd1ea24955ad2a05. --------- Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * chore: upgrade Node.js from v18.x to v20.x (#177) Updated Node.js installation source from setup_18.x to setup_20.x to align with Ubuntu 22.04 base image requirements * [Feature] DO NOT require commissioning every test (#178) * First implementation * Implement prompt and copy files from/to contanier * Unit tests * Updated SKA SHA * Unit test typo fixes * Mypy flake8 fixes * Mypy fixes * Update test_collections/matter/sdk_tests/support/python_testing/models/utils.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/utils.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Code review * Review fixes * Remove unused import --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Add logs for project config (#179) * Add logs for project config * Updated cspell.json * Update app/test_engine/test_runner.py Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Fixed unit test * Unit test * Unit test --------- Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Implement rename test run execution name (#180) * Fix the checking for storage-path (#183) * Revert code changes related to SDK path refactoring (#186) * Refatoring prompts for recommissioning (#187) * Refatoring prompts for recommissioning * flake8 fixes * Changes after code review * Revert "Utilities stress stability (#146)" (#188) * Revert "Utilities stress stability (#146)" This reverts commit 1e042fa3d07714e43132f3dd16a9fb9d211f3fd2. * Fixing wrong reverts * Fixing two more reverts * Remove commissioning information when running YAML scripts (#189) * Fix CONTAINER_TH_CLIENT_EXEC path (#191) * Fix CONTAINER_TH_CLIENT_EXEC path * Code formating * Updated SDK SHA and Python Tests JSON (#192) * Removed unused count field at test_case_metadata (#193) * Add apps folder when copying apps from container to host * Version v2.12-beta2+spring2025 * Version v2.12-beta3+spring2025 * Add apps folder when copying apps from container to host (#194) * Add apps folder when copying apps from container to host * Version v2.12-beta2+spring2025 * Version v2.12-beta2+spring2025 * [FIX] Updating Performance Files (#182) * Fixing the utils script, one calls and a import from the performance tests files * Fixing isort and cspell checks * Fixing Unit tests and removing unnecessary folder and file (jupyter) * Fix starting backend without internet access. (#184) * Remove unused file (#175) * Remove unused file * Updated cspell * [FIX] Updating Performance Files (#182) * Fixing the utils script, one calls and a import from the performance tests files * Fixing isort and cspell checks * Fixing Unit tests and removing unnecessary folder and file (jupyter) * Remove unused file (#175) * Remove unused file * Updated cspell * Fix ci issues v 2 12 (#176) * Fix CI issues from v2.12 branch * Fixed merge * Fix test case * Updated SDK_DOCKER_IMAGE url * Updated SDK_DOCKER_IMAGE url * Add nfc-thread pairing mode (#185) * Added nfc-thread pairing mode. This mode doesn't need a discriminator. * Changed after black * Unit tests fixes * Fixed code violations --------- Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> * [Fix] Recommissioning Refactoring to V1.5 (#190) * Refatoring prompts for recommissioning (#187) * Refatoring prompts for recommissioning * flake8 fixes * Changes after code review * Remove commissioning information when running YAML scripts (#189) --------- Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Updating SDK SHA to 7d67dc904758bb68989596f401a843a31e81911d in config * Updated SDK SHA * Redo code changes related to SDK path refactoring (#198) * Redo code changes related to SDK path refactoring * Putting back is_detach argument * Fix unit test --------- Co-authored-by: Romulo Quidute Filho <rquidute@apple.cpom> * Updated SDK SHA and update-sample-apps.sh * Updated sdk sha * Undo changes in update-sample-apps.sh * Utilities stress stability (#146) * draft 1 * Update * Fixing error related to multiple commissioning executions + enhancing logs * total, readcommissionininfo and discovery plots * added PASE plot and percentiles * Update PoC with support to Utility screen. * Adding support to analytics + enhancing container interface to support detach option. * Added backend service to generate summary for logDisplay * Removed unsued code * Addes URL report in response for performance_summary endpoint * Minor fixes * Fixing util method for the repeat feature of the performance tests * Merge alembic heads * Cast project config * Update method according to merged changes * Make logs directory if it doesn't exist * Add performance-logs to .gitignore * Adding the Log Display web application scripts for install, uninstall, start and stop operations * Adding support to Python Virtual Environment for the LogDisplay app scripts, plus minor changes * Fixing the repeat test feature for regular tests with more than one iteration * Removing configuration option for log folder in the LogDisplay tool for easier UX in the cost of less flexibility * Force the creation of logs/ directory as well for the LogDisplay output folder * Updating scripts and log generation to use environment variables for paths * Changing the container's log output folder for path binded with host * Updating the start script's path of the LogDisplay * Disabling SIGINT trap from the start script so the python script inside receive the Ctrl+C interruption * Adjustments on simulator script + moving matter_qa to outside endpoint + handling stress script location * Fixing lint issues. * Fix lint * fix additional lint issues * lint * fixing migration issues * Removing unnecessary code. * update log display feature. * adjustments --------- Co-authored-by: Fabio Maia <fabio_maia@apple.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> Co-authored-by: Antonio Melo Jr <a_junior@apple.com> Co-authored-by: Carolina Lopes <ccruzagralopes@apple.com> * Updated SDK SHA * Update SDK SHA * New Json for beta1 summer2025 release * Updating Beta 2 For Summer 2025 (#200) * Updating the SDK SHA * Updating the sample apps script * Updating the version information file * Removing unnecessary Jupyter folder and file * Updating the python tests information json file * Solving python black issue for github checks * Updated SDK_SHA. ble-wifi and ble-thread fixes * Change to be able to use NFC Commissioning in YAML test. (#201) * chore: upgrade Node.js from v18.x to v20.x (#177) Updated Node.js installation source from setup_18.x to setup_20.x to align with Ubuntu 22.04 base image requirements * [FIX] Updating Performance Files (#182) * Fixing the utils script, one calls and a import from the performance tests files * Fixing isort and cspell checks * Fixing Unit tests and removing unnecessary folder and file (jupyter) * Fix starting backend without internet access. (#184) * Remove unused file (#175) * Remove unused file * Updated cspell * Add support for configuring terms and conditions in device commissioning (#173) * Add support for configuring terms and conditions in device commissioning This commit introduces a new `enhanced_setup_flow` configuration property to the test harness backend, allowing device manufacturers to define the terms and conditions (T&C) that must be acknowledged and set during device commissioning. These values are critical for supporting the Terms and Conditions Certification Test Suite. Key changes include: - Added the `EnhancedSetupFlowConfig` class to `DutConfig`, which allows specifying the T&C version and user response required during commissioning. - Updated `generate_command_arguments` in `utils.py` to append the necessary arguments for T&C validation and the device's commissioning method. - Adjusted model validation to ensure the `enhanced_setup_flow` field is processed correctly within `DutConfig`. These changes ensure the test harness can enforce manufacturer-specific T&C values during the commissioning process, aligning with the broader requirements of T&C validation. * * Ran ./scripts/format.sh * Update test_collections/matter/test_environment_config.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update app/user_prompt_support/uploaded_file_support.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/performance_tests/utils.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/models/utils.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/models/utils.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/__init__.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Revert changes to test_collections/matter/sdk_tests/support/performance_tests/utils.py * Restyle test_environment_config.py * test: Add in-test-commissioning-method parameter for manual commissioning validation Add new parameter to control commissioning flow during tests, allowing manual validation of the commissioning process instead of auto-commissioning. This enables test cases to verify terms and conditions acknowledgements during the commissioning flow. - Add in-test-commissioning-method parameter to test flags - Support manual commissioning flow validation - Enable testing of T&C acknowledgement scenarios * Add new field "enhanced_setup_flow" to exception message * Cherry-pick test_python_parser.py from origin/main * Cherry-pick python_test_parser.py from origin/main * Revert "Cherry-pick python_test_parser.py from origin/main" This reverts commit 5d65ce5c4fd8d8e6d67cad68ceea52b999f1dacd. * Revert "Cherry-pick test_python_parser.py from origin/main" This reverts commit 2cd99b7fde26e2d676a55c0b135d2618e89eda52. * Removed broken test `test_python_parser.py` * Revert "Removed broken test `test_python_parser.py`" This reverts commit 48c0e323bdaf8b07ba1b6e9dcd1ea24955ad2a05. --------- Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * [Feature] DO NOT require commissioning every test (#178) * First implementation * Implement prompt and copy files from/to contanier * Unit tests * Updated SKA SHA * Unit test typo fixes * Mypy flake8 fixes * Mypy fixes * Update test_collections/matter/sdk_tests/support/python_testing/models/utils.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/utils.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Code review * Review fixes * Remove unused import --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Add logs for project config (#179) * Add logs for project config * Updated cspell.json * Update app/test_engine/test_runner.py Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Fixed unit test * Unit test * Unit test --------- Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Implement rename test run execution name (#180) * Fix the checking for storage-path (#183) * [FIX] Updating Performance Files (#182) * Fixing the utils script, one calls and a import from the performance tests files * Fixing isort and cspell checks * Fixing Unit tests and removing unnecessary folder and file (jupyter) * Remove unused file (#175) * Remove unused file * Updated cspell * Fix ci issues v 2 12 (#176) * Fix CI issues from v2.12 branch * Fixed merge * Fix test case * Updated SDK_DOCKER_IMAGE url * Updated SDK_DOCKER_IMAGE url * Add logs for project config (#179) * Add logs for project config * Updated cspell.json * Update app/test_engine/test_runner.py Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Fixed unit test * Unit test * Unit test --------- Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Add logs for project config (#179) * Add logs for project config * Updated cspell.json * Update app/test_engine/test_runner.py Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Fixed unit test * Unit test * Unit test --------- Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Add nfc-thread pairing mode (#185) * Added nfc-thread pairing mode. This mode doesn't need a discriminator. * Changed after black * Unit tests fixes * Fixed code violations --------- Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> * Add logs for project config (#179) * Add logs for project config * Updated cspell.json * Update app/test_engine/test_runner.py Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * Fixed unit test * Unit test * Unit test --------- Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> * [Fix] Recommissioning Refactoring to V1.5 (#190) * Refatoring prompts for recommissioning (#187) * Refatoring prompts for recommissioning * flake8 fixes * Changes after code review * Remove commissioning information when running YAML scripts (#189) --------- Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Change to be able to use NFC Commissioning in YAML test. NB: Change for Python tests will be done in another PR. * Fixed the error found by black and Flake8. * Added comment --------- Co-authored-by: James Swan <122404367+swan-amazon@users.noreply.github.com> Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> * [FIX] Removing Performance Collection From PICS Validation (#202) * Removing Performance collection from PICS applicable tests validation * Using a test collection copy instead of the original dict to prevent losing data * [FIX] Fix Custom YAML test execution (#205) * Fix Custom YAML test execution * Fixed flake8 and spellcheck * Update test_collections/matter/sdk_tests/support/yaml_tests/matter_yaml_runner.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Copy mock_server from cert-bins to host (#206) * Copy mock_server from cert-bins to host * Update test_collections/matter/scripts/update-sample-apps.sh Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * Updated SDK-SHA - 6cc5fb1 --------- Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * Implement Project config changes due to platform certification support (#207) * Allow Json file to be uploaded * Updated SDK SHA * Updated code to parser new dmp file format (xml) * Some code refinements and unit tests * Code review * Code review * Isort fix * [Feature] Platform cert implementation - Updated applicable test cases (#209) * Initial coding for platform certification support - applicable test cases * Implemented Derived product certification flow - PLAT_CERT_DONE = True * Added unit tests * Add TODO to fetch platform-test.json from connectedhome ip repo * Undo changed in config.py * Fix mypy flake8 * Update app/pics_applicable_test_cases.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Update app/pics_applicable_test_cases.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Update app/tests/pics/test_applicable_test_cases_list.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Update app/pics_applicable_test_cases.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Fixes after tests * Update app/pics_applicable_test_cases.py * Code review --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Use discriminator for nfc thread (#212) * Use discriminator for nfc_thread pairing * Undo discriminator as optional * Code review * Added platform-test.json as ignorePaths for cspell.json * Updated SDK_SHA to c60643c9a44ff6dfcc4319588e6fdec544c4a3e2 * Updated .version_information file * [FIX] Adding Timeout To Server Exit (#216) * Adding a fail-safe mechanism when stopping the chip server after a test execution * Returning missing while condition and adding a delay of 5 seconds between new tries * Fixing the while condition again and adding a log to the sleep delay in the logic * Rewording comment * Updated SDK_SHA - added air-purifier app * updated version to v2.13-beta3.1+summer2025 * Fix 1.5_in_progress missing folder (#217) * Added logs for applicable test cases (#218) * Adding the missing parameter to avoid the python's posicional argument error (#219) * Updating .version_information of backend * Copying credentials folder from SDK image * Updating version information * Fixed some platform tests not being added to applicable test cases (#220) * Fixed some platform tests not being added to applicable test cases * Code review * mypy fix * Code review * Improve platform test selection * Update app/pics_applicable_test_cases.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> --------- Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Fix platform-test.json read path * [Fix] Linter Error (#221) * Fixing linter's long line error * Removing two failing unit tests from platform Added a TODO comment with an open issue to address this problem. * Fixing flake issues * Returning missing parameter for Platform invalid json Unit Test * Move platform-test.json to collections folder (#223) * Move platform-test.json to collections folder * Fixed unused import and unit tests * Merge V2.13 sve+summer2025 into v2.13-develop (#231) * Changes for v2.13-beta4+summer2025 version (#224) * Changes for v2.13-beta4+summer2025 version * Updated path for platform-test.json file in cspell.json * Updated the affected sdk references (#226) * [Platform-Certification] Platform Certification List (#225) * Added the platform test list json and a Readme about the file in a folder in the repo root * Applying Gemini's comments * Moved the platform cert files to the matter folder * Update code due to platform test file location (#227) * Updated code after platform test location file is placed in new location * [Platform-Certification] Platform Certification List (#225) * Added the platform test list json and a Readme about the file in a folder in the repo root * Applying Gemini's comments * Moved the platform cert files to the matter folder * Fixed the right platform file path --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> * Updated python_tests (#228) * Updated SDK SHA and python_tests_info.json for v2.13-beta4+summer2025 * New endpoint for CLI execution - Simplify the process (#229) * create /cli endpoint * Changes for v2.13-beta4+summer2025 version (#224) * Changes for v2.13-beta4+summer2025 version * Updated path for platform-test.json file in cspell.json * Updated the affected sdk references (#226) * [Platform-Certification] Platform Certification List (#225) * Added the platform test list json and a Readme about the file in a folder in the repo root * Applying Gemini's comments * Moved the platform cert files to the matter folder * Update code due to platform test file location (#227) * Updated code after platform test location file is placed in new location * [Platform-Certification] Platform Certification List (#225) * Added the platform test list json and a Readme about the file in a folder in the repo root * Applying Gemini's comments * Moved the platform cert files to the matter folder * Fixed the right platform file path --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> * Updated python_tests (#228) * Updated SDK SHA and python_tests_info.json for v2.13-beta4+summer2025 * Add POST test_run_executions/cli * Remove unused code * Code review --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> * [FIX] Fix logic for platform tests selection (#230) * Fixed applicable test cases for platform test execution * Code formating * Fix the platform keys for PICS_PLAT_CERT and PICS_PLAT_CERT_DERIVED * Fixed mypy * Black fix * Updated version to v2.13-beta4.1+summer2025 * Minor changes * Fixed platform tests selection when no PICS were informed (#232) * Fixed platform tests selection when no PICS were informed * Balck and flake8 fixes * Minor code comment * [FIX] Make python script test name more flexible (#233) * Make python script test name more flexible * Add comment for the regex * Fix logix for platorm test selection (#234) * Revert "[FIX] Make python script test name more flexible (#233)" (#235) This reverts commit d1e207e64518ed9b962074a04b3318706be6074d. --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> * [Camera] Update backend to allow python testing framework to invoke perform video stream verification (#215) * Adds support to run camera app yaml test cases using camera-controller Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Apply formatter and fix action workflow failure Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Adds a hook for the python test framework to invoke video verification prompt Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Adds support for python test framework to invoke image verification prompt required for snap shot TCs Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Fix PromptOptions to enable submit button when opting for FAIL Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Apply formatter Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Fix issues reported by Black, Mypy Signed-off-by: suyambu.rm <suyambu.rm@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Update app/api/api_v1/sockets/web_sockets.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/yaml_tests/models/chip_test.py Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/models/test_case.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/models/test_case.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/models/test_case.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/models/test_case.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Evaluate prompt response for errors Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> --------- Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Signed-off-by: suyambu.rm <suyambu.rm@samsung.com> Co-authored-by: s-gatti <s.gatti@samsung.com> Co-authored-by: suyambu.rm <suyambu.rm@samsung.com> Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * Fixed stress test interaction TC_COMMISSIONING_1_0 test case (#239) * Fixed stress test interaction TC_COMMISSIONING_1_0 test case * Code review * Fix typo * Updated cspell.json * [Camera] Handle video stream socket operations in SocketConnectionManager (#241) * Handle video stream socket operations in SocketConnectionManager Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Update imports and fixes Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * review fixes Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> --------- Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Co-authored-by: s-gatti <s.gatti@samsung.com> * Added support to PICS for /test_run_executions/cli endpoint (#236) * Changes for v2.13-beta4+summer2025 version (#224) * Changes for v2.13-beta4+summer2025 version * Updated path for platform-test.json file in cspell.json * Updated the affected sdk references (#226) * [Platform-Certification] Platform Certification List (#225) * Added the platform test list json and a Readme about the file in a folder in the repo root * Applying Gemini's comments * Moved the platform cert files to the matter folder * Update code due to platform test file location (#227) * Updated code after platform test location file is placed in new location * [Platform-Certification] Platform Certification List (#225) * Added the platform test list json and a Readme about the file in a folder in the repo root * Applying Gemini's comments * Moved the platform cert files to the matter folder * Fixed the right platform file path --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> * Updated python_tests (#228) * Updated SDK SHA and python_tests_info.json for v2.13-beta4+summer2025 * New endpoint for CLI execution - Simplify the process (#229) * create /cli endpoint * Changes for v2.13-beta4+summer2025 version (#224) * Changes for v2.13-beta4+summer2025 version * Updated path for platform-test.json file in cspell.json * Updated the affected sdk references (#226) * [Platform-Certification] Platform Certification List (#225) * Added the platform test list json and a Readme about the file in a folder in the repo root * Applying Gemini's comments * Moved the platform cert files to the matter folder * Update code due to platform test file location (#227) * Updated code after platform test location file is placed in new location * [Platform-Certification] Platform Certification List (#225) * Added the platform test list json and a Readme about the file in a folder in the repo root * Applying Gemini's comments * Moved the platform cert files to the matter folder * Fixed the right platform file path --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> * Updated python_tests (#228) * Updated SDK SHA and python_tests_info.json for v2.13-beta4+summer2025 * Add POST test_run_executions/cli * Remove unused code * Code review --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> * [FIX] Fix logic for platform tests selection (#230) * Fixed applicable test cases for platform test execution * Code formating * Fix the platform keys for PICS_PLAT_CERT and PICS_PLAT_CERT_DERIVED * Fixed mypy * Black fix * Updated version to v2.13-beta4.1+summer2025 * Minor changes * Fixed platform tests selection when no PICS were informed (#232) * Fixed platform tests selection when no PICS were informed * Balck and flake8 fixes * Minor code comment * [FIX] Make python script test name more flexible (#233) * Make python script test name more flexible * Add comment for the regex * Fix logix for platorm test selection (#234) * Revert "[FIX] Make python script test name more flexible (#233)" (#235) This reverts commit d1e207e64518ed9b962074a04b3318706be6074d. * Added support to PICS for /test_run_executions/cli endpoint * Update app/api/api_v1/endpoints/test_run_executions.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update app/api/api_v1/endpoints/test_run_executions.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update app/api/api_v1/endpoints/test_run_executions.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update app/api/api_v1/endpoints/test_run_executions.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update app/api/api_v1/endpoints/test_run_executions.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Code review * Code review * back and flake8 --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Optimize sideload process (#237) * Changes for v2.13-beta4+summer2025 version (#224) * Changes for v2.13-beta4+summer2025 version * Updated path for platform-test.json file in cspell.json * Updated the affected sdk references (#226) * [Platform-Certification] Platform Certification List (#225) * Added the platform test list json and a Readme about the file in a folder in the repo root * Applying Gemini's comments * Moved the platform cert files to the matter folder * Update code due to platform test file location (#227) * Updated code after platform test location file is placed in new location * [Platform-Certification] Platform Certification List (#225) * Added the platform test list json and a Readme about the file in a folder in the repo root * Applying Gemini's comments * Moved the platform cert files to the matter folder * Fixed the right platform file path --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> * Updated python_tests (#228) * Updated SDK SHA and python_tests_info.json for v2.13-beta4+summer2025 * New endpoint for CLI execution - Simplify the process (#229) * create /cli endpoint * Changes for v2.13-beta4+summer2025 version (#224) * Changes for v2.13-beta4+summer2025 version * Updated path for platform-test.json file in cspell.json * Updated the affected sdk references (#226) * [Platform-Certification] Platform Certification List (#225) * Added the platform test list json and a Readme about the file in a folder in the repo root * Applying Gemini's comments * Moved the platform cert files to the matter folder * Update code due to platform test file location (#227) * Updated code after platform test location file is placed in new location * [Platform-Certification] Platform Certification List (#225) * Added the platform test list json and a Readme about the file in a folder in the repo root * Applying Gemini's comments * Moved the platform cert files to the matter folder * Fixed the right platform file path --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> * Updated python_tests (#228) * Updated SDK SHA and python_tests_info.json for v2.13-beta4+summer2025 * Add POST test_run_executions/cli * Remove unused code * Code review --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> * [FIX] Fix logic for platform tests selection (#230) * Fixed applicable test cases for platform test execution * Code formating * Fix the platform keys for PICS_PLAT_CERT and PICS_PLAT_CERT_DERIVED * Fixed mypy * Black fix * Updated version to v2.13-beta4.1+summer2025 * Minor changes * Fixed platform tests selection when no PICS were informed (#232) * Fixed platform tests selection when no PICS were informed * Balck and flake8 fixes * Minor code comment * [FIX] Make python script test name more flexible (#233) * Make python script test name more flexible * Add comment for the regex * Fix logix for platorm test selection (#234) * Revert "[FIX] Make python script test name more flexible (#233)" (#235) This reverts commit d1e207e64518ed9b962074a04b3318706be6074d. * Optimize Ssideload process * Code review * Code review * Code review - MYPY --------- Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> * [Fix] - Fix import test harness client (#243) * Fixed test_harness_client.py import * Undo set manual_execution value to 1 * Changes for V2.14 beta1+fall2025 version (#244) * Updated SDK SHA and version for v2.14-beta1+fall2025 * Updated python_tests_info.json file * Handle errors for groups commands * Update test_collections/matter/sdk_tests/support/python_testing/list_python_tests_classes.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Code review --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Updating with v2.14-beta1.1+winter2025 release (#247) * Updating with v2.14-beta1.1+winter2025 release * Updating again SDK SHA and python tests info json file * Updated unit test to not modify .version_information file (#253) * Updated unit test to not modify .version_information file * Isort and black * Code review - gemini * Code review * Added support to project_id in test_run_executions POST /cli (#252) * Added support to project_id in test_run_executions POST /cli * black and isort * Update app/api/api_v1/endpoints/test_run_executions.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Flake8 * Fixed unit tests * black * Update app/tests/api/api_v1/test_test_run_executions.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Code review --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Fix POST testrun_executions/cli not using config when project id is informed (#254) * RUn POST testrun_executions/cli not using config when project id is informed * mypy, black, flake8 * flake8 * black * Fixes raised by Gemini in PR#250 (#255) * Minor changes raised by gamini in PR#250 * Code review - Gemini * [FIX] Updated TH after SDK refactoring (#258) * Updated TH after SDK refactoring * Update test_collections/matter/sdk_tests/scripts/fetch_sdk_tests_and_runner.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Version v2.14-beta2+fall2025 (#259) * Version v2.14-beta2+fall2025 * Updated cspell * [Camera] Push AV validation prompt support (#251) * Adds push av validation prompt Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Apply formatter Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Address review comments Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> --------- Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Co-authored-by: s-gatti <s.gatti@samsung.com> * [Camera] Add signaling endpoints for WebRTC (#256) * Add signaling endpoints for WebRTC Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * linting fixes Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * fix mypy issue Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Log error messages Signed-off-by: Charles Kim <chulspro.kim@samsung.com> --------- Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Co-authored-by: abhishek.h <abhishek.h@samsung.com> * [Camera] Adds pop up for two way talk verification request (#257) * Adds pop up for two way talk verification request Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Address review comments Signed-off-by: Charles Kim <chulspro.kim@samsung.com> --------- Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * black * Updated fetch_sdk_tests_and_runner script to install chipyaml wheel (#260) * Updated fetch_sdk_tests_and_runner script to install chipyaml wheel * updated cspell.json file * Update test_collections/matter/sdk_tests/scripts/fetch_sdk_tests_and_runner.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Code review - gemini * Update test_collections/matter/sdk_tests/scripts/fetch_sdk_tests_and_runner.sh Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * [Fix] Fix missing python script in TH UI (#261) * Updated fetch_sdk_tests_and_runner script to install chipyaml wheel * updated cspell.json file * Update test_collections/matter/sdk_tests/scripts/fetch_sdk_tests_and_runner.sh Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Code review - gemini * Fix logic for Python scripts be listed as test script * Added python_tests_info.json file * Code review - gemini * added pyproject to ignore words in cspell * Mypy * Mypy --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * v2.14-beta2.1+fall2025 version (#262) * v2.14-beta2.1+fall2025 version * Updated .version_information * Restore msg argument in SDKPythonTestResultShowTwoWayTalkPrompt (#263) Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Co-authored-by: s-gatti <s.gatti@samsung.com> * [Enhancement] Dynamic generate python_test_info.json file (#264) * Dynamic generate python_test_info.json file * Empty python_test_info file * Add python_test_info.json file to .gitignore file * Unit test fix * flake8 * Fix unit test * Removed python_tests_info.json file (#265) * [Fix] Update filename pattern validation for python test files (#266) * Update logic to list python scripts * Code review * Code review * Updated code comment * Updated unit test * Updated unit test * Updated unit tests * flake8 * Updated unit tests * Updated code comment * black * Updated argument handling in test_harness_client (#270) * Updated argument handling in test_harness_client * Update test_collections/matter/sdk_tests/support/python_testing/models/rpc_client/test_harness_client.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Code review - gemini * Code review * Mypy * Update code comment * Update test_collections/matter/sdk_tests/support/python_testing/models/rpc_client/test_harness_client.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/models/rpc_client/test_harness_client.py Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> * Fixing sdk container arguments by always passing thread and wifi info (#268) * v2.14-beta3+fall2025 version * Updated SDK version to 966e378dab819d3abd4a59b468dc61d80b8b4b41 * Updated SDK SHA to f902839abf1de0d17956de34889b6ad997e2c5e4 * Fix error handling in Python test list generation to prevent KeyError (#271) * Improve list_python_tests_classes.py file * Code formating * Update test_collections/matter/sdk_tests/support/python_testing/list_python_tests_classes.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/list_python_tests_classes.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * mypy * cspell updated * Remove unnecessary comments --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Fix python script listing (#272) * Fix python script listing * Added feature to files that should be included despite regex * Code review * Code review * Refactoring method to read ignore and include file * Updated SDK_SHA after some scripts fixes * Implement real-time log synchronization for Python test steps (#267) * Allow realtime logging for python scripts * Some performance improvements * Code review * Code review - mypu * Code review --------- Co-authored-by: Romulo Quidute Filho <romuloquidute@gmail.com> * Add sdk docker image sha info (#273) * Added sdk_docker_tag info * Print whole SDK_DOCKER_TAG instead of only 7 digits * Unit test refactoring * Updated type hint * Updared cspell.json * Disable Polkit in chip-cert-bins (#269) * Polkit should be disabled when PCSC reader is used in a Docker container. Change-Id: I6889fd99972f19cbbfc80623cf9a6bb29155dda2 * Update test_collections/matter/sdk_tests/support/python_testing/models/test_suite.py Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Changes following code review. Change-Id: Ic41e6d205440714dd526d1aeaad52c6ce1f8cfbe * Change following code review Change-Id: I159b72d1a8fd9adadf74d8b4692960c9dbbc2cdf * Change from Romulo Change-Id: Idfc456d037ac8ff4296c83193400fc4bc8f14dbb --------- Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> * Feature/763 use argparse test harness client (#274) * Improve test_harness_client by using argparse * Code review * Added commissioning logs (#275) * Added commissioning logs * Update test_collections/matter/sdk_tests/support/python_testing/models/utils.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/models/utils.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Flake8 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * [FEATURE] Add equivalent shell command logs when using docker api (#276) * Add equivalent shell command when using docker api * Update app/container_manager/docker_shell_commands.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update app/container_manager/docker_shell_commands.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update app/container_manager/docker_shell_commands.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/sdk_container.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update app/container_manager/docker_shell_commands.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update app/container_manager/docker_shell_commands.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Code review * Flake8 * Code review * Code review * Code review --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * [Fix] Moved Shared Constants To New File (#277) * Created shared constants script and added two Enums to the file * Adding MessageKeysEnum as shared, removed original and changing all related imports * Adding TestStateEnum and changing all relevant imports * Exchanging for a app relative import in the models' init file * Updating Copyright's Date Year * Reverting python_tests SHA since it's not ready yet * Updating Matter test scripts SHA * [Feature] Improve Python Testing Initialization (#278) * Creating test manager and updating code logic to improve Python Testing initialization * Updating file's year and removing Optional import from test manager * Removing code duplication * Adding forward reference type hint to Python Testing init * Removing unnecessary imports and changing a too long line error from the test manager * Removing unnecessary comment * Get changes from v2.14-develop into v2.15-develop (#280) * Updated SDK version to 68e03c17300eb42c0d3946130aa2a8f7a2a06632 for v1.5 final release * Updated SDK_SHA to ca9d1118e097fe947b2aec1ba84f265d6cf2447e * Update .version_information Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> --------- Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> * Feature/785 make log synchronization configurable (#279) * Updated SDK version to 68e03c17300eb42c0d3946130aa2a8f7a2a06632 for v1.5 final release * Updated SDK_SHA to ca9d1118e097fe947b2aec1ba84f265d6cf2447e * Implement code to make log synchronization configurable * Run black * Code review * Updated python_tests submodule * Code review * Updating SDK SHA for the v2.15-beta1+winter2025 release (Matter 1.6 TE1) * [FIX] Custom Suite And Custom TC Naming (#282) * Fixing Custom Name for presentation and adding symbolic links for easy access to the custom folders * Gemini's suggestion: Improving readability for the custom suffix variable processing logic * Fixing Backend's API for the CLI Test Run Execution (#283) * Fixing Backend's API for the CLI Test Run Execution * Gemini suggestions: Updating logic for efficiency Also avoiding modifying external variable. * Solve flake8 error in singleton.py file * Fix permission denied errors in update-paa-certs.sh by force recreating directories (#285) * Fix update-paa-certs.sh permission error * Code review * [Feature] Adding chip-server information API (#284) * Adding chip-server information API * Updating endpoint to use Chip Server Info schema * Add support to sort the test run execution list and retrieve all records without pagination (#286) * Add sort_order to GET test_run_execution * Add support to sort results and retrive all records from test_run_execution * Update app/tests/crud/test_test_run_execution.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update app/crud/crud_test_run_execution.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update app/crud/crud_test_run_execution.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Improved logic to load json file, while launching. This avoids unpredicable unit tests failing due to race condition * Flake8 * Code review - Mock read python test JSON file * Code review - organize imports and remove useless code * Code review - flake8 * Code review - flake8 * Code review - fix unit test * Code revier * Code review --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * [Feature] Updating CHIP Server Info Endpoint to Include Manual Pairing Code (#287) * Updating CHIP Server Info endpoint to include Manual Pairing Code * Gemini's Suggestion: Improving logic * Adding break to leave out of the for loop as soon as possible * Skip load custom tests step if no custom tests were found (#288) * Skip load custom tests step if no custom tests were found * Update test_collections/matter/sdk_tests/support/python_testing/test_manager.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * [Feature] Adding Support to CLI's Double-Dash Extra Arguments Feature (#289) * Adding support to the CLI's double dash extra arguments feature * Improving logic and fixing comment * Updating endpoint's comments Adding note for the scenario where both configs are provided * Implemented configuration for enabling/disabling container information logging (#290) * Implemented configuration for enabling/disabling container information logging * Code review - Gemini * Fixes for Python tests being loaded twice during Test Harness startup (#291) * Fixes for Python tests being loaded twice during Test Harness startup * Code review * Updated backend version v2.15-beta2+spring2026 (#292) * Updated SDK SHA to 9b1078da4307f98d362a0b44625a94d649bc1e77 for v2.14.1-beta1+winter2026 version * Version v2.14.1-beta2+winter2026 * [Feature] TH to support thread commissioning (#295) * Initial code for thread support * Code formating and isort * Apply suggestion from @gemini-code-assist[bot] Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Apply suggestion from @gemini-code-assist[bot] Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Apply suggestion from @gemini-code-assist[bot] Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Code review - gemini-code-assistant * Code review - gemini-code-assistant * Code review - gemini-code-assistant * Code review flake8 - gemini-code-assistant * Code review mypy --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Adding nfc-wifi to the backend rebased to V2.15-develop (#294) * Adding nfc-wifi to the backend * Keeping Flake8 happy * Making another tool happy * improvents according to Gemini * refactor updates throughout necessary files * reverting change in test_suite.py * updates according to Gemini * updates to keep tools happy * tooling update * Version v2.15-beta2.1+spring2026 * Fixed imports in test_harness_client.py file (#297) * Updated all references from Thread to Thread_meshcop (#299) * Updated all references from Thread to Thread_meshcop * Code formating * Updated SDK_SHA * [Fix] Argument Generation When Using NFC Commissioning (#298) * Fixing argument generation when using NFC commissioning Dut config shouldn't pass discrminator, passcode, manual code or qr-code when using NFC pairing mode * Fixing unit tests * Improving logic and exchangin data structure from list to set * Fix the Python test script parser to correctly identify base test classes imported from additional Matter SDK modules. (#300) * Fix python script parser * Code review - gemini * Code review - adjust endswith for TestBase in python script parser * Code review - mypy fix * Version v2.15-beta2.2+spring2026 * Fix/888 include missing tests (#302) * Improved logic to load python test scripts * Added test_python_test_initialization.py unit test file * Update copyright year * Code review - mypy/flake8 * Code review - mypy/flake8 * Code review - mypy/flake8 * Code review - flake8 * Update test_collections/matter/sdk_tests/support/python_testing/list_python_tests_classes.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update test_collections/matter/sdk_tests/support/python_testing/list_python_tests_classes.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Code review - gemini code assist * Code review --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Fix json-arg not working (#304) * Fix json-arg not working * Code review- Gemini Code assist * Code review- Gemini Code assist * Code review- Gemini Code assist * Added more unit test in order to covert more scenarios * Release Matter 1.6 SVE (v2.15-beta3+spring2026) * Release Matter 1.6 SVE version 2 (v2.15-beta3.1+spring2026) * [FIX] Updating Test Run Executions To Handle temporary PICS (#305) * Updating infrastructure to handle temporary PICS for Test Run Executions * Fixing test_run_executions.py docstring * Improving return expression in the test_run.py file * Fixing the related unit tests * Removing unnecessary import * Fix custom sideloaded test scripts not appearing in the test list when their base class is defined in support_modules (#306) * Consider using extra dir(SDK files) when discovering custom test cases * Code review - Google code assist * Fix black * Remove commissioning prompt from no commissioning tests (#307) * Remove commissioning prompt from no commissioning suite * Fix mypy * Code review * Make pcscd --disable-polkit started unconditionally (#309) * Fix TC_DD_3_24 hang on user prompt timeout in _show_prompt_request (#308) * Fix TC_DD_3_24 hang on user prompt timeout in _show_prompt_request. When wait_for_user_input times out, response_str is None so nothing was sent to the test socket, leaving the SDK process blocked on input() forever. * Update test_collections/matter/sdk_tests/support/python_testing/models/test_case.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Code review --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Fix ImportError for CommissionDeviceTest in test_harness_client (#312) CommissionDeviceTest has been moved from matter.testing.commissioning to matter.testing.CommissioningPreTest in the Matter SDK. The old path no longer exports this symbol, which causes --get-test-info to fail and the Python test list to be empty in the UI. Fixes #981 * Annotate grouped log download for api generation (#313) * v2.15+spring2026 version (#315) * Fix ModuleNotFoundError - matter.testing.CommissioningPreTest (#316) --------- Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Signed-off-by: suyambu.rm <suyambu.rm@samsung.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.com> Co-authored-by: Romulo Quidute Filho <116586593+rquidute@users.noreply.github.com> Co-authored-by: antonio-amjr <116589331+antonio-amjr@users.noreply.github.com> Co-authored-by: hiltonlima <116589806+hiltonlima@users.noreply.github.com> Co-authored-by: Carolina Lopes <116589288+ccruzagralopes@users.noreply.github.com> Co-authored-by: James Swan <122404367+swan-amazon@users.noreply.github.com> Co-authored-by: Olivier LORENTE [ST] <34505085+OlivierGre@users.noreply.github.com> Co-authored-by: Antonio Melo Jr. <a_junior@apple.com> Co-authored-by: Romulo Quidute Filho <rquidute@apple.cpom> Co-authored-by: gladystonfranca <117387464+gladystonfranca@users.noreply.github.com> Co-authored-by: Fabio Maia <fabio_maia@apple.com> Co-authored-by: Carolina Lopes <ccruzagralopes@apple.com> Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> Co-authored-by: chulspro <chulspro.kim@samsung.com> Co-authored-by: s-gatti <s.gatti@samsung.com> Co-authored-by: suyambu.rm <suyambu.rm@samsung.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: abhishek.h <abhishek.h@samsung.com> Co-authored-by: Romulo Quidute Filho <romuloquidute@gmail.com> Co-authored-by: Arnold Braine <arnold.braine@gmail.com> Co-authored-by: Steven Green <sgreen@csa-iot.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding support for nfc-wifi rebased to V2.15-develop using the reference pull requests from @OlivierGre
Add nfc-thread pairing mode #185
Change to be able to use NFC Commissioning in YAML test. #201
Disable Polkit in chip-cert-bins #269