Skip to content

[Fix] Passing Thread And Wi-Fi Data Always #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonio-amjr merged 1 commit into from
Oct 10, 2025
Merged

[Fix] Passing Thread And Wi-Fi Data Always #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions test_collections/matter/sdk_tests/support/python_testing/models/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,16 +82,15 @@ async def generate_command_arguments(
else:
arguments.append(f"--commissioning-method {pairing_mode}")

if pairing_mode == DutPairingModeEnum.BLE_WIFI:
arguments.append(f"--wifi-ssid {config.network.wifi.ssid}")
arguments.append(f"--wifi-passphrase {config.network.wifi.password}")

if (
pairing_mode == DutPairingModeEnum.BLE_THREAD
or pairing_mode == DutPairingModeEnum.NFC_THREAD
):
dataset_hex = await __thread_dataset_hex(config.network.thread)
arguments.append(f"--thread-dataset-hex {dataset_hex}")
if pairing_mode == DutPairingModeEnum.BLE_WIFI:
arguments.append(f"--wifi-ssid {config.network.wifi.ssid}")
arguments.append(f"--wifi-passphrase {config.network.wifi.password}")
elif (
pairing_mode == DutPairingModeEnum.BLE_THREAD
or pairing_mode == DutPairingModeEnum.NFC_THREAD
):
Comment on lines +88 to +91

@gemini-code-assist gemini-code-assist Bot Oct 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to use a more Pythonic approach, you can check for membership in a tuple or set instead of using multiple or conditions. This makes the code more concise and easier to understand.

    elif pairing_mode in (DutPairingModeEnum.BLE_THREAD, DutPairingModeEnum.NFC_THREAD):

dataset_hex = await __thread_dataset_hex(config.network.thread)
arguments.append(f"--thread-dataset-hex {dataset_hex}")

# Retrieve arguments from test_parameters
if test_parameters:
Expand Down
Loading