license: document grace period + corrected warning intervals#6
Open
martinrode wants to merge 1 commit into
Open
license: document grace period + corrected warning intervals#6martinrode wants to merge 1 commit into
martinrode wants to merge 1 commit into
Conversation
The fylr license lifecycle was reworked in 6.34.0: subscription licenses are now purely time-based (the old "binary older than one year" rule no longer expires a subscription), they gain a two-month grace period after the end date during which the instance keeps working, and the warning mails were restructured into four buckets that cover the full lifecycle. This commit folds those changes into the existing docs so the gitbook matches what the code does in 6.34.0. license-management.md "fylr version expiration": - Split into subscription / buy subsections. Subscription: time-based, end date + 2-month grace; buy: unlimited in time, binary released on/before end date runs forever, binary released after is refused as "too new". Drops the obsolete "binary > 1 year" rule for subscriptions. - New "Grace period (subscription only)" subsection: defines what the grace period is, gives the grace_to formula (end date + 2 calendar months), and points out that the license info shows it. - New "Expiration warning mails" subsection listing the four mails (paid-period-ending, grace-period-ending, license-expired, binary-too-new) with the DD.MM.YYYY note, linking to the admin page for the exact intervals. for-administrators/readme/license-management.md "Expiration Warnings & Notifications": - Corrected the pre-end-date intervals from 30/5/1 to 30/7/1 days, to match the code in internal/license/validation/license_validation.go (expireEmailWarnValidTo). The previous 30/5/1 was stale. - Added the grace-period reminders (weekly from 8 weeks before grace end, daily in the last week before grace end), matching expireEmailWarnValidToGrace. - Added the license-expired and binary-too-new mails so all four mail types the code emits are documented in one place. Trac #76801 — Sebastian asked martin-ai to write the docs so they can be folded into the existing structure. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the license-management changes that shipped with fylr 6.34.0
(Trac #76801):
grace period). The previous "binary older than one year" rule no
longer applies to subscriptions; it is dropped from the docs.
documented (definition,
grace_to= end date + 2 calendar months,shown in the license manager next to the end date).
grace-period-ending, license-expired (past grace), and binary-too-new
(buy). Dates shown as DD.MM.YYYY.
for-administrators/readme/license-management.mdare corrected from30/5/1 days to 30/7/1 days, to match the code
(
expireEmailWarnValidToininternal/license/validation/license_validation.go). The previouspage had a stale interval.
grace end, daily in the last week (matches
expireEmailWarnValidToGracein the same file).Notes for review
the
grace_toformula were taken frominternal/license/license.go(
GraceMonths = 2,GraceTo()) andinternal/license/validation/license_validation.go(the twoexpireEmailWarn…slices). No discrepancies vs. the spec in the6.34.0 release-notes pending-notes block.
(paid-period-ending, grace-period-ending, license-expired,
binary-too-new) mirror the four
expire_type/ template branchesthe code emits.
(>1 year) for buy licenses"; that exception is now the only rule
for buy licenses, and the >1-year-old rule is gone for subscriptions.
Request channel
Sebastian Klarmann assigned Trac #76801 (comment:82) to
martin-aiasking for the docs to be written so they can be folded into the
existing structure. The PR fulfils that request.
Please review:
🤖 Generated with Claude Code