fix(ods): the generator is hucre, not the name the project used to have - #560
Merged
Conversation
Every ODS hucre writes has been stamping
<meta:generator>defter</meta:generator>
— the project's former name — since the ODS writer was written. The XLSX
writer has said `hucre` in `docProps/app.xml`'s `<Application>` all along,
so the two disagreed about what produced the file.
ODF §4.3.2.1 has `meta:generator` name the producing application. A
consumer that keys off it (LibreOffice records it, and support threads
routinely ask for it) was being told about software that does not exist.
The test that pinned the old string pinned it by name — "writes
Application: defter" — which is how it survived the rename.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every ODS hucre has ever written says this in
meta.xml:defteris what the project was called before it was renamed. The XLSXwriter has said
hucreindocProps/app.xml's<Application>the wholetime, so the two writers disagreed about what produced the file, and one
of them was naming software that does not exist.
ODF §4.3.2.1 has
meta:generatorname the producing application —LibreOffice records it on open, and it is the first thing asked for when a
document is reported as malformed. Anyone tracing a bad ODS back to its
producer had a name with no project behind it.
Why it lasted this long
The test that pinned it pinned it by name:
A rename sweep over the source finds
defterin a string literal andstops, because a test asserts it — the test looks like the requirement
rather than a copy of it. Renaming the test as well is the point: it now
says "names itself as the generator", which stays true through the next
rename.
The surviving
Defters insrc/errors.tsare the deliberate deprecatedDefterErroralias and stay.pnpm testgreen — 10,583 tests, 234 files. The ODS output stillvalidates against the OASIS grammar.
🤖 Generated with Claude Code