Skip to content

test(xlsx): validate the comments, theme and app properties as well #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
productdevbook merged 1 commit into from
Aug 13, 2026
Merged

test(xlsx): validate the comments, theme and app properties as well #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions scripts/validate-ooxml.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
//
// A chart is DrawingML, not SpreadsheetML — `sml.xsd` has never heard of
// `c:chartSpace` — so each part is checked against the schema that
// describes it rather than all of them against one.
// describes it rather than all of them against one. The theme is
// DrawingML too, and `docProps/app.xml` has its own shared schema.
//
// Two things to know before reading its output.
//
Expand Down Expand Up @@ -250,13 +251,26 @@ function partsToCheck(pkg, schemaDir) {
for (const part of all) {
if (/^xl\/(workbook|styles|sharedStrings)\.xml$/.test(part)) out.push([part, schema])
else if (/^xl\/(worksheets|tables)\/[^/]+\.xml$/.test(part)) out.push([part, schema])
else if (/^xl\/comments\d+\.xml$/.test(part)) out.push([part, schema])
else if (/^xl\/charts\/chart\d+\.xml$/.test(part)) {
out.push([part, join(schemaDir, "dml-chart.xsd")])
} else if (/^xl\/drawings\/drawing\d+\.xml$/.test(part)) {
out.push([part, join(schemaDir, "dml-spreadsheetDrawing.xsd")])
} else if (part === "xl/theme/theme1.xml") {
// The theme is DrawingML, like the charts.
out.push([part, join(schemaDir, "dml-main.xsd")])
} else if (part === "docProps/app.xml") {
out.push([part, join(schemaDir, "shared-documentPropertiesExtended.xsd")])
}
// Relationship parts, content types, docProps and VML have their own
// schemas elsewhere in the package and are not this script's business.
// Not checked, and why:
//
// [Content_Types].xml, *.rels, docProps/core.xml their schemas are
// in ECMA-376 Part 2 (OPC), a separate download from the Part 4
// set this script asks for.
// xl/drawings/vmlDrawing*.vml `vml-main.xsd`
// does not load in `javax.xml.validation` at all — it throws
// before reading any document. VML is a legacy format with a
// famously loose schema, and this is not the place to fight it.
}
return out
}
Expand Down
Loading