Repository navigation
Conversation
…r data on sign-out The daily challenge and own text get their ids in @typing-race/curriculum (dailyId/isDailyId, ownTextId/isOwnTextId, isFreePracticeId). The server does not know these ids and answers unknown_scale, which the outbox keeps and re-sends forever, so sync stayed "pending" and sign-out stopped. - submitAttempt stores free practice locally but never queues it - free practice an older build queued is dropped from the outbox - wipeLocalIfSynced/forgetLocal also remove typing-race:daily* and typing-race:sprint-best:* (the guide-seen flag stays: it is a per-browser UI hint with no learner data) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Own text records under ownTextId (yq.owntext), not the stock real-text id, and is labelled "Свій текст"/"Own text" on the result screen - Free practice (daily and own text) is ignored by mastery/progress, key confidence and weak spots (derive), the coach's last attempt, XP, the streak and daily-goal minutes (gameStats), and the result reward - /own hides the practice/test toggle (always practice); "Again" on an own-text result re-runs the same text from memory, or opens /own when it is gone - The "cut to N characters" notice shows on the pre-start card - Daily done-today and the day count are kept per language Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the review of Daily challenge and Own text:
.dailyitem an older build queued is dropped, so sync no longer stays "pending" and sign-out goes through. The id helpers moved to@typing-race/curriculum(dailyId/isDailyId,ownTextId/isOwnTextId,isFreePracticeId), soderive.tsno longer imports fromfeatures/. No server deploy needed.yq.owntext): ignored by mastery/progress, key confidence and weak spots, XP, streak and daily-goal minutes, the result reward and the outbox, and labelled "Свій текст"/"Own text". Daily attempts are now ignored by the streak, daily goal and weak spots as well./ownform.typing-race:daily:<lang>).typing-race:daily*andtyping-race:sprint-best:*together with the local copy.typing-race:guide-seenis kept on purpose: it is a per-browser UI hint and holds no learner data.Tests: unit tests for the id predicates, the outbox rule, the local-key wipe, the free-practice filters (derive, gameStats, reward) and the per-language daily. There is a new
e2e/owntext.spec.ts(chromium, 2/2 passing).pnpm buildstays under the initial-JS budget (148.8 KB gzip).🤖 Generated with Claude Code