Pin GitHub Actions in release workflow to commit SHAs#87
Open
HodaSalim wants to merge 1 commit into
Open
Conversation
The procore-oss org requires all actions to be pinned to a full-length commit SHA. The Release workflow was failing this check on every push to main, which is why gem version 1.1.0 was never published. Pin each action to the commit its tag currently points to, matching the procore-oss/blueprinter release workflow. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Hoda Salim <hoda.s.salim@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
34ec509 to
e7faa5a
Compare
bunnrf
approved these changes
Jul 1, 2026
andrew-wheeler
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
procore-ossorg enforces that all GitHub Actions must be pinned to a full-length commit SHA (a supply-chain security measure). TheReleaseworkflow used mutable tags (@v4,@v44,@v1,@v2) and was therefore blocked on every push tomain, failing in ~7s before doing any work.lib/sift/version.rbonmainreads1.1.0, but RubyGems' latestprocore-siftis still1.0.0.procore-oss/blueprinterrelease workflow. No behavior change beyond making the references immutable.actions/checkoutde0fac2e4500dabe0009e67214ff5f5447ce83dd# v4tj-actions/changed-files934b2d2c7e653bb8c968afed5a0428617f09aa24# v44ruby/setup-ruby9eb537ca036ebaed86729dcb9309076e4c5c3b74# v1fac/ruby-gem-setup-credentials-action5f62d5f2f56a11c7422a92f81fbb29af01e1c00f# v2fac/ruby-gem-push-actionb2b56ea12bd8eb96b1add0befca8a9726b652078# v2Test plan
Releaseworkflow no longer fails the action-pinning check after this merges.version.rbchange in this push). Publish 1.1.0 by manually running the workflow:gh workflow run release.yaml --ref main.Made with Cursor