Add mat2 uniform support to WebGL setUniform, fixing silent no-op (#8…#8978
Open
harshiltewari2004 wants to merge 1 commit into
Open
Add mat2 uniform support to WebGL setUniform, fixing silent no-op (#8…#8978harshiltewari2004 wants to merge 1 commit into
harshiltewari2004 wants to merge 1 commit into
Conversation
Continuous ReleaseCDN linkPublished PackagesCommit hash: db05648 Previous deploymentsThis is an automated message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8939
Changes
FLOAT_MAT2case to thesetUniformswitch insrc/webgl/utils.js(gl.uniformMatrix2fv), mirroring the existingmat3/mat4 cases — completing part of the
//@todoFLOAT_MAT2to theisArrayclassification ingetWebGLUniformMetadata, so mat2 uniforms take the array path inp5.Shader's value caching
createFilterShaderwith auniform mat2driving the fragment color from the matrix diagonal). Verified the test
fails on unfixed code and passes with the fix.
Note: there was previously no direct setUniform test coverage for matrix
uniforms of any size, in either backend — this test establishes the pattern.
mat2 remains untested on the WebGPU side (where it already works); happy to
add a WGSL counterpart in a follow-up if wanted.
While verifying with a full test run, I hit an intermittent failure in
Typography > textWeight > can control non-variable fonts— unrelated tothis change (2D-mode test, no path to the modified code; passes repeatedly
in isolation on this branch). It loads its font from Google Fonts at test
time, which is the likely flake source.
PR Checklist
npm run lintpasses