Arijit/cuda linting - #8
Merged
Merged
Conversation
horizon-blue
approved these changes
Nov 17, 2025
horizon-blue
left a comment
horizon-blue
left a comment
Contributor
There was a problem hiding this comment.
Nice work!
I think the more idiomatic way of integrating CUDA with clang/llvm toolkits is to configure clang to use cuda-specific knowledge (e.g. NVIDIA/cccl/.clangd, which is a bit less hacky than what we're currently doing 🤔. Still, if the current set of rules works, let's get this merged now so people can start developing based on the initial scaffolding :). Thank you for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some suppressions to the linting, to handle CUDA (for now). This is a temporary patch that we should re-visit in the future. (PART OF MET-26)