feat(wallets): add create wrapper for crypto deposit accounts - #201
Closed
ss-privy wants to merge 1 commit into
Closed
feat(wallets): add create wrapper for crypto deposit accounts#201ss-privy wants to merge 1 commit into
ss-privy wants to merge 1 commit into
Conversation
Stainless only emits _create on Node for this auth-context endpoint. Add the public create method that signs via authorization_context, matching earn.deposit. Co-authored-by: Cursor <cursoragent@cursor.com> Committed-By-Agent: cursor
Contributor
Author
|
Closing in favor of #202. Same wrapper; 202 also applies Thirteen Grok reviews of this PR were 13–0 SHIP; none of the deltas in 202 were blockers, but they were the repeated should-fix items. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stainless generates
_createfor Node on this endpoint (AuthContextBackingMethods) because TypeScript cannot overloadcreatewith an authorization-context argument. This adds the publiccreatewrapper that signs viaauthorization_context, the same pattern aswallets().earn().ethereum().deposit().Base is
main(notnext) so this sits on top of the generated crypto deposit_createfromfeat(api): api update.Test plan
tsc --noEmitpassescreateshows up onclient.wallets().depositAccounts.cryptoafter installMade with Cursor