Repository navigation
fix(vault): preserve node position in tree when editing existing connection or folder - #36
Open
AlissonAraldi wants to merge 1 commit into
Open
AlissonAraldi wants to merge 1 commit into
AlissonAraldi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
VaultManager::upsertremoves any existing node with the matching id and inserts it at the end of the parent's children (u.doc.remove(id)followed byinsert_into(...)). This scrambles the user's manual ordering of connections whenever an existing connection or folder is updated.Changes
find_parent_idandreplace_ininsrc-tauri/src/vault/manager.rs.upsert_existing_preserves_positionverifying order is preserved across edits.