Use compatible tolerance for tests - #573
Merged
Merged
Conversation
Owner
|
Which version of {RSpectra} should I use to test this? |
Contributor
Author
|
The develop branch will be the upcoming RSpectra 0.17-0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @privefl, recently I was preparing for the new version of
RSpectra, and I encountered some numerical issues in the reverse dependency tests. One of them is related to the comparison betweenpcadapt::pcadapt()andbigstatsr::big_randomSVD(). The issue is that both of these two functions use a default tolerance of 1e-4, butexpect_equal()has a default value roughly at the order of 1e-8.I think it makes more sense to explicitly declare the precision in computing the SVD, and then use a compatible tolerance for
expect_equal(). Let me know if you have any questions. Thank you!